Fix query and API bugs: 403 for non-owners, page bounds, lifecycle filters, cover fallback, race-safe inserts, async album delete

2026-09-24 05:14:05 +02:00
parent ab388e6ad6
commit 0e3576922f
90 changed files with 2083 additions and 322 deletions
@@ -9,6 +9,8 @@ internal static class ActivityNames
    internal const string MarkPlayListAsFailed = "MarkPlayListAsFailed";
    internal const string DeletePlayListFromDb = "DeletePlayListFromDb";
    internal const string MarkAlbumAsFailed = "MarkAlbumAsFailed";
+    internal const string MarkAlbumAsRemoving = "MarkAlbumAsRemoving";
+    internal const string DeleteAlbumFromDb = "DeleteAlbumFromDb";

    internal const string GenerateAudioWorkflowPaths = "GenerateAudioWorkflowPaths";
    internal const string GeneratePictureWorkflowPaths = "GeneratePictureWorkflowPaths";
@@ -55,4 +57,7 @@ internal static class ActivityNames
    internal const string RemovePlayListLargePicture = "RemovePlayListLargePicture";

    internal const string RemoveAlbumOriginalPicture = "RemoveAlbumOriginalPicture";
+    internal const string RemoveAlbumSmallPicture = "RemoveAlbumSmallPicture";
+    internal const string RemoveAlbumMediumPicture = "RemoveAlbumMediumPicture";
+    internal const string RemoveAlbumLargePicture = "RemoveAlbumLargePicture";
 }
@@ -0,0 +1,93 @@
+using MassTransit;
+using MassTransit.Courier.Contracts;
+using Microsoft.EntityFrameworkCore;
+using Musify.Application.Configuration;
+using Musify.Application.Contracts;
+using Musify.Infrastructure.MassTransit.Activities.Files;
+using Musify.Infrastructure.MassTransit.Activities.Albums;
+using Musify.Infrastructure.MassTransit.Arguments;
+using Musify.Infrastructure.MassTransit.Consumers;
+
+namespace Musify.Infrastructure.MassTransit.RoutingSlip.Builders;
+
+public class DeleteAlbumRoutingSlipBuilder(
+    IDatabase database,
+    AlbumConfiguration albumConfiguration,
+    ApplicationStorageConfiguration storageConfiguration)
+{
+    public async Task<RoutingSlipBuilder> BuildAsync(
+        Guid albumId,
+        long userId,
+        Guid? correlationId,
+        CancellationToken cancellationToken)
+    {
+        var routingSlipBuilder = new RoutingSlipBuilder(NewId.NextGuid());
+        routingSlipBuilder.AddVariable(RoutingSlipVariableNames.Workflow.CorrelationId, correlationId ?? Guid.Empty);
+
+        routingSlipBuilder.AddSubscription(
+            EndpointHelper.BuildConsumerUri(RoutingSlipCleanUpConsumer.QueueName),
+            RoutingSlipEvents.Completed | RoutingSlipEvents.Faulted);
+
+        var album = await database.Albums
+            .AsNoTracking()
+            .SingleOrDefaultAsync(p => p.Id == albumId, cancellationToken);
+
+        routingSlipBuilder.AddActivity(
+            ActivityNames.MarkAlbumAsRemoving,
+            EndpointHelper.BuildExecuteActivityUri(MarkAlbumAsRemovingActivity.ExecuteEndpointName),
+            new MarkAlbumAsRemovingArguments(albumId));
+
+        if (album?.Pictures != null)
+        {
+            var bucket = storageConfiguration.Bucket;
+            var routes = albumConfiguration.Routes;
+
+            if (album.Pictures.OriginalName is { } originalName)
+            {
+                routingSlipBuilder.AddActivity(
+                    ActivityNames.RemoveAlbumOriginalPicture,
+                    EndpointHelper.BuildExecuteActivityUri(RemoveFileFromBucketActivity.ExecuteEndpointName),
+                    new RemoveFileFromBucketArguments(
+                        bucket,
+                        routes.BuildOriginalPicturePath(userId, originalName)));
+            }
+
+            if (album.Pictures.SmallName is { } smallName)
+            {
+                routingSlipBuilder.AddActivity(
+                    ActivityNames.RemoveAlbumSmallPicture,
+                    EndpointHelper.BuildExecuteActivityUri(RemoveFileFromBucketActivity.ExecuteEndpointName),
+                    new RemoveFileFromBucketArguments(
+                        bucket,
+                        routes.BuildSmallPicturePath(smallName)));
+            }
+
+            if (album.Pictures.MediumName is { } mediumName)
+            {
+                routingSlipBuilder.AddActivity(
+                    ActivityNames.RemoveAlbumMediumPicture,
+                    EndpointHelper.BuildExecuteActivityUri(RemoveFileFromBucketActivity.ExecuteEndpointName),
+                    new RemoveFileFromBucketArguments(
+                        bucket,
+                        routes.BuildMediumPicturePath(mediumName)));
+            }
+
+            if (album.Pictures.LargeName is { } largeName)
+            {
+                routingSlipBuilder.AddActivity(
+                    ActivityNames.RemoveAlbumLargePicture,
+                    EndpointHelper.BuildExecuteActivityUri(RemoveFileFromBucketActivity.ExecuteEndpointName),
+                    new RemoveFileFromBucketArguments(
+                        bucket,
+                        routes.BuildLargePicturePath(largeName)));
+            }
+        }
+
+        routingSlipBuilder.AddActivity(
+            ActivityNames.DeleteAlbumFromDb,
+            EndpointHelper.BuildExecuteActivityUri(DeleteAlbumFromDbActivity.ExecuteEndpointName),
+            new DeleteAlbumFromDbArguments(albumId));
+
+        return routingSlipBuilder;
+    }
+}