Fix query and API bugs: 403 for non-owners, page bounds, lifecycle filters, cover fallback, race-safe inserts, async album delete

web-player/src/routes/(app)/playlists/+page.server.ts

@@ -7,6 +7,8 @@ import {
 	unwrapOrError
 } from '$lib/server/api';
 import { uploadPresignedImage } from '$lib/server/upload';
+import { fetchAllPages } from '$lib/server/pagination';
+import { PLAYLIST_TRACKS_LIMIT } from '$lib/config';
 
 const MAX_NAME = 100;
 
@@ -21,11 +23,15 @@ export const load: PageServerLoad = async ({ locals, url, fetch }) => {
 
 	const tracksByPlaylist = await Promise.all(
 		data.items.map((playlist) =>
-			api
-				.GET('/playlists/{playlistId}/tracks', {
-					params: { path: { playlistId: playlist.id }, query: { pageNumber: 1, pageSize: 500 } }
-				})
-				.then((res) => res.data?.items ?? [])
+			fetchAllPages(
+				async (pageNumber, pageSize) =>
+					(
+						await api.GET('/playlists/{playlistId}/tracks', {
+							params: { path: { playlistId: playlist.id }, query: { pageNumber, pageSize } }
+						})
+					).data,
+				PLAYLIST_TRACKS_LIMIT
+			)
 		)
 	);
 

web-player/src/routes/(app)/playlists/[id]/+page.server.ts

@@ -8,6 +8,8 @@ import {
 	unwrapOrFail
 } from '$lib/server/api';
 import { uploadPresignedImage } from '$lib/server/upload';
+import { fetchAllPages } from '$lib/server/pagination';
+import { PLAYLIST_TRACKS_LIMIT } from '$lib/config';
 
 const MAX_NAME = 100;
 
@@ -16,15 +18,20 @@ export const load: PageServerLoad = async ({ params, locals, url, fetch, parent
 	optionalUser(locals, url, allowAnonymousListening);
 	const api = createApiClient({ fetch, accessToken: locals.accessToken ?? undefined });
 
-	const [playlistRes, tracksRes] = await Promise.all([
+	const [playlistRes, tracks] = await Promise.all([
 		api.GET('/playlists/{id}', { params: { path: { id: params.id } } }),
-		api.GET('/playlists/{playlistId}/tracks', {
-			params: { path: { playlistId: params.id }, query: { pageNumber: 1, pageSize: 200 } }
-		})
+		fetchAllPages(
+			async (pageNumber, pageSize) =>
+				(
+					await api.GET('/playlists/{playlistId}/tracks', {
+						params: { path: { playlistId: params.id }, query: { pageNumber, pageSize } }
+					})
+				).data,
+			PLAYLIST_TRACKS_LIMIT
+		)
 	]);
 
 	const playlist = unwrapOrError(playlistRes, 'Playlist no encontrada.', 404);
-	const tracks = tracksRes.data?.items ?? [];
 
 	return { playlist, tracks };
 };

web-player/src/routes/+layout.server.ts

@@ -3,7 +3,8 @@ import type { LayoutServerLoad } from './$types';
 import { getAllowAnonymousListening } from '$lib/server/playbackConfig';
 import { createApiClient } from '$lib/server/api';
 import { authConfig } from '$lib/server/config';
-import { LIKED_TRACKS_PAGE_SIZE } from '$lib/config';
+import { LIKED_TRACKS_LIMIT } from '$lib/config';
+import { fetchAllPages } from '$lib/server/pagination';
 
 const PUBLIC_PATHS = new Set(['/auth']);
 const SIDEBAR_PLAYLISTS_LIMIT = 8;
@@ -30,10 +31,11 @@ async function fetchSidebarPlaylists(
 async function fetchLikedTracks(fetchFn: typeof fetch, accessToken: string | null) {
 	try {
 		const api = createApiClient({ fetch: fetchFn, accessToken: accessToken ?? undefined });
-		const { data } = await api.GET('/likes', {
-			params: { query: { pageNumber: 1, pageSize: LIKED_TRACKS_PAGE_SIZE } }
-		});
-		return data?.items ?? [];
+		return await fetchAllPages(
+			async (pageNumber, pageSize) =>
+				(await api.GET('/likes', { params: { query: { pageNumber, pageSize } } })).data,
+			LIKED_TRACKS_LIMIT
+		);
 	} catch {
 		return [];
 	}