Split TrackApplicationResponse into a Local/External hierarchy

Same treatment as AlbumApplicationResponse, but Track is the cleaner case: OwnerUserId (local-only) and ExternalId (external-only) are both genuinely exclusive to one side, so the base carries neither and is abstract — every real value is one of the two derived types. TrackApplicationResponse (abstract, shared fields + FromEntity dispatch) LocalTrackApplicationResponse (+ OwnerUserId) ExternalTrackApplicationResponse (+ ExternalId) Hit a real gotcha along the way: the response already had an explicit Source property, which collides with the "source" discriminator STJ's polymorphism support injects ("contains property 'source' that conflicts with an existing metadata property name" — only surfaced at runtime in the Api integration tests, not at build time). Fixed by dropping the now-redundant explicit Source field entirely; the discriminator already serializes the identical "Local"/"YouTube" value under the same name, so the wire contract is unchanged. Updated the two call sites that read .Source directly (TrackSearchItemResponse and a playlist track filter that needed flatMap instead of filter().map() to keep the narrowing across the chain).
2026-09-10 19:19:59 +02:00
parent 7ae6c0a7a2
commit 10766bbb47
9 changed files with 144 additions and 32 deletions
@@ -0,0 +1,30 @@
+using Musify.Domain.Entities;
+using Musify.Domain.ValueObjects;
+
+namespace Musify.Application.Tracks.Responses
+{
+    public record ExternalTrackApplicationResponse(
+        Guid Id,
+        string Title,
+        string? Artist,
+        ProcessingStatus AudioStatus,
+        double Duration,
+        int ListensCount,
+        DateTime CreatedAt,
+        DateTime UpdatedAt,
+        string ExternalId)
+        : TrackApplicationResponse(Id, Title, Artist, AudioStatus, Duration, ListensCount, CreatedAt, UpdatedAt)
+    {
+        public static ExternalTrackApplicationResponse FromEntity(ExternalTrack track, int listensCount) =>
+            new(
+                track.Id,
+                track.Title,
+                FormatArtist(track),
+                track.Audio.TranscodeStatus,
+                track.DurationSeconds,
+                listensCount,
+                track.CreatedAt,
+                track.UpdatedAt,
+                track.ExternalId);
+    }
+}