From 1769df12d50563b5aaf578e0380b3d8366dfc699 Mon Sep 17 00:00:00 2001 From: XShine555 Date: Mon, 6 Jul 2026 02:12:58 +0200 Subject: [PATCH] refactor(search): treat empty search strings as no filter (string.IsNullOrEmpty) --- backend/Musify.Application/PlayLists/GetPlayListsByUserId.cs | 2 +- backend/Musify.Application/Tracks/GetTracks.cs | 2 +- backend/Musify.Application/Tracks/GetTracksByUserId.cs | 2 +- backend/Musify.Application/Users/GetUsers.cs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/backend/Musify.Application/PlayLists/GetPlayListsByUserId.cs b/backend/Musify.Application/PlayLists/GetPlayListsByUserId.cs index 4d21c1b..b0062da 100644 --- a/backend/Musify.Application/PlayLists/GetPlayListsByUserId.cs +++ b/backend/Musify.Application/PlayLists/GetPlayListsByUserId.cs @@ -24,7 +24,7 @@ namespace Musify.Application.PlayLists .AsNoTracking() .Where(p => p.UserId == request.UserId); - if (request.Name is not null) + if (!string.IsNullOrEmpty(request.Name)) { var normalizedName = request.Name.Trim().ToUpperInvariant(); playListsQuery = playListsQuery.Where(p => p.NormalizedName.Contains(normalizedName)); diff --git a/backend/Musify.Application/Tracks/GetTracks.cs b/backend/Musify.Application/Tracks/GetTracks.cs index 377cd91..f29a33e 100644 --- a/backend/Musify.Application/Tracks/GetTracks.cs +++ b/backend/Musify.Application/Tracks/GetTracks.cs @@ -24,7 +24,7 @@ namespace Musify.Application.Tracks .Include(ut => ut.Track) .AsQueryable(); - if (request.Name is not null) + if (!string.IsNullOrEmpty(request.Name)) { var normalizedName = request.Name.Trim().ToUpperInvariant(); tracksQuery = tracksQuery.Where(t => t.Track.NormalizedTitle.Contains(normalizedName)); diff --git a/backend/Musify.Application/Tracks/GetTracksByUserId.cs b/backend/Musify.Application/Tracks/GetTracksByUserId.cs index 657aa2e..b6ae5fd 100644 --- a/backend/Musify.Application/Tracks/GetTracksByUserId.cs +++ b/backend/Musify.Application/Tracks/GetTracksByUserId.cs @@ -28,7 +28,7 @@ namespace Musify.Application.Tracks .Include(ut => ut.Track) .Where(p => p.UserId == request.UserId); - if (request.Name is not null) + if (!string.IsNullOrEmpty(request.Name)) { var normalizedName = request.Name.Trim().ToUpperInvariant(); tracksQuery = tracksQuery.Where(t => t.Track.NormalizedTitle.Contains(normalizedName)); diff --git a/backend/Musify.Application/Users/GetUsers.cs b/backend/Musify.Application/Users/GetUsers.cs index 6f57f60..0504390 100644 --- a/backend/Musify.Application/Users/GetUsers.cs +++ b/backend/Musify.Application/Users/GetUsers.cs @@ -20,7 +20,7 @@ namespace Musify.Application.Users .AsNoTracking() .AsQueryable(); - if (request.UsernameSearch is not null) + if (!string.IsNullOrEmpty(request.UsernameSearch)) { var normalizedUsername = request.UsernameSearch.Trim().ToUpperInvariant(); user = user.Where(u => u.NormalizedName.Contains(normalizedUsername));