Enable more analyzers, drop log-and-rethrow in file activities and apply dotnet format

Use invariant culture when formatting ids, put cancellation tokens last in endpoint handlers, remove the
CS8618 pragmas and keep only the analyzer overrides that still apply.

backend/Core/Musify.Infrastructure/MassTransit/Activities/Files/CopyFileInBucketActivity.cs

@@ -15,28 +15,16 @@ internal class CopyFileInBucketActivity(
 
     public async Task<ExecutionResult> Execute(ExecuteContext<CopyFileInBucketArguments> executeContext)
     {
-        try
-        {
-            await storageService.CopyFileAsync(
-                executeContext.Arguments.SourceBucket,
-                executeContext.Arguments.SourceKey,
-                executeContext.Arguments.DestinationBucket,
-                executeContext.Arguments.DestinationKey,
-                executeContext.CancellationToken);
+        await storageService.CopyFileAsync(
+            executeContext.Arguments.SourceBucket,
+            executeContext.Arguments.SourceKey,
+            executeContext.Arguments.DestinationBucket,
+            executeContext.Arguments.DestinationKey,
+            executeContext.CancellationToken);
 
-            return executeContext.Completed(new CopyFileInBucketLog(
-                executeContext.Arguments.DestinationBucket,
-                executeContext.Arguments.DestinationKey));
-        }
-        catch (Exception exception)
-        {
-            logger.LogError(exception, "Failed to copy {SourceBucket}/{SourceKey} to {DestinationBucket}/{DestinationKey}",
-                executeContext.Arguments.SourceBucket,
-                executeContext.Arguments.SourceKey,
-                executeContext.Arguments.DestinationBucket,
-                executeContext.Arguments.DestinationKey);
-            throw;
-        }
+        return executeContext.Completed(new CopyFileInBucketLog(
+            executeContext.Arguments.DestinationBucket,
+            executeContext.Arguments.DestinationKey));
     }
 
     public async Task<CompensationResult> Compensate(CompensateContext<CopyFileInBucketLog> compensateContext)

backend/Core/Musify.Infrastructure/MassTransit/Activities/Files/DownloadFileFromBucketActivity.cs

@@ -18,33 +18,25 @@ internal class DownloadFileFromBucketActivity(
         var destinationPath = executeContext.GetVariable<string>(executeContext.Arguments.DestinationFilePathVariable);
         ArgumentNullException.ThrowIfNull(destinationPath);
 
-        try
-        {
-            using var fileStream = await storageService.GetFileAsync(
-                executeContext.Arguments.Bucket,
-                executeContext.Arguments.Key,
-                executeContext.CancellationToken)
-                ?? throw new FileNotFoundException($"Object {executeContext.Arguments.Bucket}/{executeContext.Arguments.Key} was not found.");
+        using var fileStream = await storageService.GetFileAsync(
+            executeContext.Arguments.Bucket,
+            executeContext.Arguments.Key,
+            executeContext.CancellationToken)
+            ?? throw new FileNotFoundException($"Object {executeContext.Arguments.Bucket}/{executeContext.Arguments.Key} was not found.");
 
-            var destinationDirectory = Path.GetDirectoryName(destinationPath);
-            if (!string.IsNullOrWhiteSpace(destinationDirectory))
-                Directory.CreateDirectory(destinationDirectory);
+        var destinationDirectory = Path.GetDirectoryName(destinationPath);
+        if (!string.IsNullOrWhiteSpace(destinationDirectory))
+            Directory.CreateDirectory(destinationDirectory);
 
-            if (fileStream.CanSeek)
-                fileStream.Position = 0;
+        if (fileStream.CanSeek)
+            fileStream.Position = 0;
 
-            using var destinationStream = File.Create(destinationPath);
-            await fileStream.CopyToAsync(destinationStream, executeContext.CancellationToken);
-            return executeContext.Completed(new DownloadFileFromBucketLog(
-                executeContext.Arguments.Bucket,
-                executeContext.Arguments.Key,
-                destinationPath));
-        }
-        catch (Exception exception)
-        {
-            logger.LogError(exception, "Failed to download file from bucket");
-            throw;
-        }
+        using var destinationStream = File.Create(destinationPath);
+        await fileStream.CopyToAsync(destinationStream, executeContext.CancellationToken);
+        return executeContext.Completed(new DownloadFileFromBucketLog(
+            executeContext.Arguments.Bucket,
+            executeContext.Arguments.Key,
+            destinationPath));
     }
 
     public Task<CompensationResult> Compensate(CompensateContext<DownloadFileFromBucketLog> compensateContext)

backend/Core/Musify.Infrastructure/MassTransit/Activities/Files/RemoveFileFromBucketActivity.cs

@@ -34,12 +34,5 @@ internal class RemoveFileFromBucketActivity(
                 executeContext.Arguments.Bucket);
             return executeContext.Completed();
         }
-        catch (Exception exception)
-        {
-            logger.LogError(exception, "Failed to remove {Key} from bucket {Bucket}",
-                executeContext.Arguments.Key,
-                executeContext.Arguments.Bucket);
-            throw;
-        }
     }
 }

backend/Core/Musify.Infrastructure/MassTransit/Activities/Files/TransferFilesToBucketActivity.cs

@@ -20,25 +20,15 @@ internal class TransferFilesToBucketActivity(
         var destinationKey = executeContext.Arguments.DestinationKey;
         ArgumentNullException.ThrowIfNull(destinationKey);
 
-        try
-        {
-            var uploadedKeys = await storageService.TransferFilesAsync(
-                folderPath,
-                executeContext.Arguments.DestinationBucket,
-                destinationKey,
-                executeContext.CancellationToken);
+        var uploadedKeys = await storageService.TransferFilesAsync(
+            folderPath,
+            executeContext.Arguments.DestinationBucket,
+            destinationKey,
+            executeContext.CancellationToken);
 
-            return executeContext.Completed(new TransferFilesToBucketLog(
-                executeContext.Arguments.DestinationBucket,
-                uploadedKeys.ToArray()));
-        }
-        catch (Exception exception)
-        {
-            logger.LogError(exception, "Failed to transfer files from {FolderPath} to {DestinationBucket}",
-                folderPath,
-                executeContext.Arguments.DestinationBucket);
-            throw;
-        }
+        return executeContext.Completed(new TransferFilesToBucketLog(
+            executeContext.Arguments.DestinationBucket,
+            uploadedKeys.ToArray()));
     }
 
     public async Task<CompensationResult> Compensate(CompensateContext<TransferFilesToBucketLog> compensateContext)

backend/Core/Musify.Infrastructure/MassTransit/Activities/Files/UploadFileToBucketActivity.cs

@@ -21,22 +21,14 @@ internal class UploadFileToBucketActivity(IStorageService storageService,
             .Where(static s => !string.IsNullOrWhiteSpace(s))
             .Select(static s => s.Trim().Trim('/', '\\')));
 
-        try
-        {
-            await storageService.UploadFileAsync(
-                sourceFilePath,
-                executeContext.Arguments.DestinationBucket,
-                destinationKey,
-                executeContext.CancellationToken);
-            return executeContext.CompletedWithVariables(new UploadFileToBucketLog(
-                executeContext.Arguments.DestinationBucket,
-                destinationKey));
-        }
-        catch (Exception exception)
-        {
-            logger.LogError(exception, "Failed to upload file to bucket");
-            throw;
-        }
+        await storageService.UploadFileAsync(
+            sourceFilePath,
+            executeContext.Arguments.DestinationBucket,
+            destinationKey,
+            executeContext.CancellationToken);
+        return executeContext.CompletedWithVariables(new UploadFileToBucketLog(
+            executeContext.Arguments.DestinationBucket,
+            destinationKey));
     }
 
     public async Task<CompensationResult> Compensate(CompensateContext<UploadFileToBucketLog> compensateContext)