Enable more analyzers, drop log-and-rethrow in file activities and apply dotnet format

Use invariant culture when formatting ids, put cancellation tokens last in endpoint handlers, remove the
CS8618 pragmas and keep only the analyzer overrides that still apply.

backend/Hosts/Musify.Api/Endpoints/AlbumEndpoints.cs

@@ -129,9 +129,9 @@ public static class AlbumEndpoints
 
     private static async Task<IResult> GetAlbums(
         IMediator mediator,
-        CancellationToken cancellationToken,
         string? title,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetAlbumsQuery(title, page.PageNumber, page.PageSize), cancellationToken);
         return Results.Ok(result);
@@ -149,8 +149,8 @@ public static class AlbumEndpoints
     private static async Task<IResult> GetAlbumsByUserId(
         IMediator mediator,
         long userId,
-        CancellationToken cancellationToken,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetAlbumsByUserIdQuery(userId, page.PageNumber, page.PageSize), cancellationToken);
         return result.ToHttpResult();
@@ -177,8 +177,8 @@ public static class AlbumEndpoints
     private static async Task<IResult> GetAlbumTracks(
         IMediator mediator,
         Guid id,
-        CancellationToken cancellationToken,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetAlbumTracksQuery(id, page.PageNumber, page.PageSize), cancellationToken);
         return result.ToHttpResult();

backend/Hosts/Musify.Api/Endpoints/LikeEndpoints.cs

@@ -38,8 +38,8 @@ public static class LikeEndpoints
     private static async Task<IResult> GetLikedTracks(
         IMediator mediator,
         CurrentUser currentUser,
-        CancellationToken cancellationToken,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetLikedTracksQuery(currentUser.RequiredId, page.PageNumber, page.PageSize), cancellationToken);
         return Results.Ok(result);

backend/Hosts/Musify.Api/Endpoints/PlayListEndpoints.cs

@@ -125,9 +125,9 @@ public static class PlayListEndpoints
         IMediator mediator,
         CurrentUser currentUser,
         long userId,
-        CancellationToken cancellationToken,
         string? name,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetPlayListsByUserIdQuery(userId, name, page.PageNumber, page.PageSize, currentUser.Id), cancellationToken);
         return Results.Ok(result);
@@ -137,8 +137,8 @@ public static class PlayListEndpoints
         IMediator mediator,
         CurrentUser currentUser,
         Guid id,
-        CancellationToken cancellationToken,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetPlayListTracksQuery(id, page.PageNumber, page.PageSize, currentUser.Id), cancellationToken);
         return result.ToHttpResult();

backend/Hosts/Musify.Api/Endpoints/TrackEndpoints.cs

@@ -97,10 +97,10 @@ public static class TrackEndpoints
 
     private static async Task<IResult> GetTracks(
         IMediator mediator,
-        CancellationToken cancellationToken,
         string? name,
         GenreParameter? genre,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetTracksQuery(name, page.PageNumber, page.PageSize, genre?.Value), cancellationToken);
         return Results.Ok(result);
@@ -152,9 +152,9 @@ public static class TrackEndpoints
     private static async Task<IResult> GetTracksByUserId(
         IMediator mediator,
         long userId,
-        CancellationToken cancellationToken,
         string? name,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetTracksByUserIdQuery(userId, name, page.PageNumber, page.PageSize), cancellationToken);
         return result.ToHttpResult();

backend/Hosts/Musify.Api/Endpoints/UserEndpoints.cs

@@ -100,9 +100,9 @@ public static class UserEndpoints
     private static async Task<IResult> GetUsers(
         IMediator mediator,
         CurrentUser currentUser,
-        CancellationToken cancellationToken,
         string? usernameSearch,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetUsersQuery(page.PageNumber, page.PageSize, usernameSearch, currentUser.Id), cancellationToken);
         return Results.Ok(result);
@@ -162,8 +162,8 @@ public static class UserEndpoints
         IMediator mediator,
         CurrentUser currentUser,
         long id,
-        CancellationToken cancellationToken,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetUserFollowersQuery(currentUser.Id, id, page.PageNumber, page.PageSize), cancellationToken);
         return result.ToHttpResult();
@@ -173,8 +173,8 @@ public static class UserEndpoints
         IMediator mediator,
         CurrentUser currentUser,
         long id,
-        CancellationToken cancellationToken,
-        [AsParameters] PageQuery page)
+        [AsParameters] PageQuery page,
+        CancellationToken cancellationToken)
     {
         var result = await mediator.Send(new GetUserFollowingQuery(currentUser.Id, id, page.PageNumber, page.PageSize), cancellationToken);
         return result.ToHttpResult();