Make album cover pictures mandatory, unify cover handling with playlists

Albums previously had no cover concept at all: no picture upload flow, no GET /albums/{id}/cover, and AlbumApplicationResponse's image-key fields were plumbed but never populated. Description, Pictures and TrackCount already lived on the shared Album base entity for both local and external albums, so unifying the cover story only required building the missing local-album picture pipeline. Backend, cloning PlayList's existing async picture-processing architecture exactly (MassTransit routing slip + saga), but making the picture mandatory instead of optional (matching Track's pattern): - AlbumPictures moves from all-nullable to required fields. - New AlbumConfiguration (routes/sizes), deliberately without PlayList's preset-picture fallback since a picture is now required up front. - CreateAlbum now takes a mandatory PictureIntentId, validates and consumes the upload intent, and kicks off the same copy-to-final -> resize -> upload -> update-entity routing slip PlayLists use, via a new AlbumProcessingState saga that marks the album Failed on a picture-processing failure. - UpdateAlbum takes an optional NewPictureIntentId to replace the cover later. - New GET /albums/{id}/cover and POST /albums/upload-picture endpoints, mirroring the playlist ones. - New EF migration for the AlbumProcessingState saga table. Frontend: - AlbumForm gains a cover dropzone, required on create and optional on edit (via ImageDropzone's new `required` prop), uploaded through the same presigned-upload helper playlists use. - New /api/albums/{id}/cover proxy route. - PlaylistArt gains a generic coverUrl prop so AlbumHeader and the album list/detail cards render the real uploaded cover instead of only the track mosaic fallback. Delete-time picture cleanup for albums is intentionally left as a follow-up, matching the existing gap in playlist deletion.
2026-09-10 15:04:36 +02:00
parent 29a7fed6a5
commit 478b90d75c
63 changed files with 3118 additions and 383 deletions
@@ -0,0 +1,32 @@
+using MassTransit;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.Extensions.Logging;
+using Musify.Application.Contracts;
+using Musify.Domain.ValueObjects;
+using Musify.Infrastructure.MassTransit.Arguments;
+
+namespace Musify.Infrastructure.MassTransit.Activities.Albums
+{
+    internal class MarkAlbumAsFailedActivity(
+        IDatabase database,
+        ILogger<MarkAlbumAsFailedActivity> logger)
+        : IExecuteActivity<MarkAlbumAsFailedArguments>
+    {
+        public const string ExecuteEndpointName = "mark-album-as-failed";
+
+        public async Task<ExecutionResult> Execute(ExecuteContext<MarkAlbumAsFailedArguments> executeContext)
+        {
+            var album = await database.Albums
+                .SingleOrDefaultAsync(a => a.Id == executeContext.Arguments.AlbumId, executeContext.CancellationToken);
+
+            if (album is not null)
+            {
+                album.LifeCycleStatus = LifeCycleStatus.Failed;
+                await database.SaveChangesAsync(executeContext.CancellationToken);
+                logger.LogInformation("Marked album {AlbumId} as failed", executeContext.Arguments.AlbumId);
+            }
+
+            return executeContext.Completed();
+        }
+    }
+}
@@ -0,0 +1,34 @@
+using MassTransit;
+using Microsoft.Extensions.Logging;
+using Musify.Application.Events;
+using Musify.Infrastructure.MassTransit.Arguments;
+
+namespace Musify.Infrastructure.MassTransit.Activities.Albums
+{
+    internal class PublishAlbumPictureProcessingEventActivity(
+        IPublishEndpoint publishEndpoint,
+        ILogger<PublishAlbumPictureProcessingEventActivity> logger)
+        : IExecuteActivity<PublishAlbumPictureProcessingEventArguments>
+    {
+        public const string ExecuteEndpointName = "publish-album-picture-processing-event";
+
+        public async Task<ExecutionResult> Execute(ExecuteContext<PublishAlbumPictureProcessingEventArguments> executeContext)
+        {
+            var arguments = executeContext.Arguments;
+
+            await publishEndpoint.Publish(
+                new UpdateAlbumPictureEvent(
+                    arguments.AlbumId,
+                    arguments.Bucket,
+                    arguments.FinalPictureKey,
+                    arguments.Small,
+                    arguments.Medium,
+                    arguments.Large),
+                executeContext.CancellationToken);
+
+            logger.LogInformation("Published picture processing event for album {AlbumId}", arguments.AlbumId);
+
+            return executeContext.Completed();
+        }
+    }
+}
@@ -0,0 +1,113 @@
+using MassTransit;
+using Microsoft.Extensions.Logging;
+using Musify.Application.Contracts;
+using Musify.Application.Events;
+using Musify.Domain.ValueObjects;
+using Musify.Infrastructure.MassTransit.Arguments;
+using Musify.Infrastructure.MassTransit.Logs;
+
+namespace Musify.Infrastructure.MassTransit.Activities.Pictures
+{
+    internal class UpdateAlbumPictureActivity(
+        IDatabase database,
+        IPublishEndpoint publishEndpoint,
+        ILogger<UpdateAlbumPictureActivity> logger)
+        : IActivity<UpdateAlbumPictureArguments, UpdateAlbumPictureLog>
+    {
+        public const string ExecuteEndpointName = "update-album-picture";
+
+        public async Task<ExecutionResult> Execute(ExecuteContext<UpdateAlbumPictureArguments> executeContext)
+        {
+            var smallResizedVariable = executeContext.GetVariable<string>(executeContext.Arguments.SmallPictureVariable);
+            ArgumentNullException.ThrowIfNull(smallResizedVariable, nameof(smallResizedVariable));
+            var mediumResizedVariable = executeContext.GetVariable<string>(executeContext.Arguments.MediumPictureVariable);
+            ArgumentNullException.ThrowIfNull(mediumResizedVariable, nameof(mediumResizedVariable));
+            var largeResizedVariable = executeContext.GetVariable<string>(executeContext.Arguments.LargePictureVariable);
+            ArgumentNullException.ThrowIfNull(largeResizedVariable, nameof(largeResizedVariable));
+
+            try
+            {
+                var album = await database.Albums.FindAsync(
+                    [executeContext.Arguments.AlbumId],
+                    cancellationToken: executeContext.CancellationToken);
+
+                if (album is null)
+                {
+                    logger.LogWarning("Album {AlbumId} not found",
+                        executeContext.Arguments.AlbumId);
+                    throw new InvalidOperationException($"Album with id {executeContext.Arguments.AlbumId} not found");
+                }
+
+                if (album.Pictures is null)
+                {
+                    logger.LogWarning("Album {AlbumId} has no pending picture upload",
+                        executeContext.Arguments.AlbumId);
+                    throw new InvalidOperationException($"Album with id {executeContext.Arguments.AlbumId} has no pending picture upload");
+                }
+
+                var log = new UpdateAlbumPictureLog(
+                    album.Id,
+                    album.Pictures.OriginalName,
+                    album.Pictures.SmallName,
+                    album.Pictures.MediumName,
+                    album.Pictures.LargeName);
+
+                album.Pictures.OriginalName = Path.GetFileName(executeContext.Arguments.OriginalPictureKey);
+                album.Pictures.SmallName = Path.GetFileName(smallResizedVariable);
+                album.Pictures.MediumName = Path.GetFileName(mediumResizedVariable);
+                album.Pictures.LargeName = Path.GetFileName(largeResizedVariable);
+
+                database.Albums.Update(album);
+                await database.SaveChangesAsync(executeContext.CancellationToken);
+
+                logger.LogInformation("Updated album {AlbumId} pictures",
+                    executeContext.Arguments.AlbumId);
+
+                await publishEndpoint.Publish(
+                    new AlbumPictureProcessed(executeContext.Arguments.AlbumId),
+                    executeContext.CancellationToken);
+
+                return executeContext.Completed();
+            }
+            catch (Exception exception)
+            {
+                logger.LogError(exception, "Failed to update album {AlbumId} pictures",
+                    executeContext.Arguments.AlbumId);
+                throw;
+            }
+        }
+
+        public async Task<CompensationResult> Compensate(CompensateContext<UpdateAlbumPictureLog> compensateContext)
+        {
+            try
+            {
+                var album = await database.Albums.FindAsync(
+                    [compensateContext.Log.AlbumId],
+                    cancellationToken: compensateContext.CancellationToken);
+
+                if (album is null)
+                {
+                    return compensateContext.Compensated();
+                }
+
+                album.Pictures = new AlbumPictures
+                {
+                    OriginalName = compensateContext.Log.PreviousOriginalPictureKey,
+                    SmallName = compensateContext.Log.PreviousSmallPictureKey,
+                    MediumName = compensateContext.Log.PreviousMediumPictureKey,
+                    LargeName = compensateContext.Log.PreviousLargePictureKey
+                };
+
+                database.Albums.Update(album);
+                await database.SaveChangesAsync(compensateContext.CancellationToken);
+
+                return compensateContext.Compensated();
+            }
+            catch (Exception exception)
+            {
+                logger.LogError(exception, "Failed to compensate album {AlbumId} pictures", compensateContext.Log.AlbumId);
+                return compensateContext.Failed(exception);
+            }
+        }
+    }
+}