Clean up domain entities: shared picture value object, lifecycle and ownership interfaces, explicit tables

backend/Core/Musify.Domain/Entities/UploadIntent.cs

@@ -11,40 +11,34 @@ public class UploadIntent
     [Key]
     public Guid Id { get; set; } = Guid.NewGuid();
 
-    [Required]
     public required long UserId { get; set; }
 
-    [Required, MaxLength(128)]
+    [MaxLength(128)]
     public required string Bucket { get; set; }
 
-    [Required, MaxLength(512)]
+    [MaxLength(512)]
     public required string Key { get; set; }
 
-    [Required, MaxLength(128)]
+    [MaxLength(128)]
     public required string ObjectName { get; set; }
 
-    [Required, MaxLength(128)]
+    [MaxLength(128)]
     public required string ContentType { get; set; }
 
     public long? ExpectedSizeBytes { get; set; }
 
-    [Required]
     public UploadIntentPurpose Purpose { get; set; }
 
-    [Required]
     public UploadIntentStatus Status { get; set; } = UploadIntentStatus.Issued;
 
-    [Required]
     public DateTime ExpiresAt { get; set; }
 
-    [Required]
     public DateTime CreatedAt { get; set; } = DateTime.UtcNow;
 
     [NotMapped]
     public bool IsConsumed => Status == UploadIntentStatus.Consumed;
 
-    [NotMapped]
-    public bool IsExpired => Status == UploadIntentStatus.Expired || ExpiresAt < DateTime.UtcNow;
+    public bool IsExpiredAt(DateTime now) => Status == UploadIntentStatus.Expired || ExpiresAt < now;
 
     [ForeignKey(nameof(UserId))]
     public User User { get; set; } = null!;