From 6da1e8d5cd53cf9e9da8f41a71685b6ef985932d Mon Sep 17 00:00:00 2001 From: XShine555 Date: Mon, 1 Jun 2026 22:11:48 +0200 Subject: [PATCH] Simplify user sync: rely on EF change tracking instead of manual hasChanges flag --- .../Users/Handlers/SyncUserCommandHandler.cs | 37 ++++--------------- 1 file changed, 7 insertions(+), 30 deletions(-) diff --git a/Application/Users/Handlers/SyncUserCommandHandler.cs b/Application/Users/Handlers/SyncUserCommandHandler.cs index 0686829..61aabb8 100644 --- a/Application/Users/Handlers/SyncUserCommandHandler.cs +++ b/Application/Users/Handlers/SyncUserCommandHandler.cs @@ -34,38 +34,15 @@ namespace Musify.Application.Users.Handlers return Result.Success(); } - var hasChanges = false; + user.Name = request.Name; + user.NormalizedName = request.Name.ToUpperInvariant(); + user.FirstName = request.FirstName; + user.SecondName = request.SecondName; + user.ProfilePictureUrl = request.ProfilePictureUrl; - if (user.Name != request.Name) - { - user.Name = request.Name; - user.NormalizedName = request.Name.ToUpperInvariant(); - hasChanges = true; - } - - if (user.FirstName != request.FirstName) - { - user.FirstName = request.FirstName; - hasChanges = true; - } - - if (user.SecondName != request.SecondName) - { - user.SecondName = request.SecondName; - hasChanges = true; - } - - if (user.ProfilePictureUrl != request.ProfilePictureUrl) - { - user.ProfilePictureUrl = request.ProfilePictureUrl; - hasChanges = true; - } - - if (hasChanges) - { - await database.SaveChangesAsync(cancellationToken); + var written = await database.SaveChangesAsync(cancellationToken); + if (written > 0) logger.LogInformation("Synced profile for user {UserId}", request.Id); - } return Result.Success(); }