NotS1mp/Musify
0
0
Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(infra): S3 client singleton, ffmpeg pipe ordering, tidy streams/jobs

Browse Source 
- Register IAmazonS3 as a singleton instead of scoped: the AWS SDK client is
  thread-safe and manages its own connection pool, so one instance per DI scope
  (per request / per job iteration) was wasteful and risked socket exhaustion
- AudioTranscoderService: start reading stdout/stderr before writing stdin to
  remove the latent pipe-buffer deadlock shape
- Dispose the resized-picture MemoryStream in ResizePictureActivity
- Background jobs use PeriodicTimer instead of while + Task.Delay

Verified: Worker boots against RabbitMQ + Postgres in Docker with no captive-
dependency error (dev scope validation) and both jobs start.

Build: 0 warnings, 0 errors.
This commit is contained in:
Admin
2026-07-05 15:07:49 +02:00
parent 93ee8be0cd
commit 6e4b8fad56
5 changed files with 20 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/Musify.Infrastructure/Services/AudioTranscoderService.cs
+10 -5
View File
@@ -103,13 +103,16 @@ namespace Musify.Infrastructure.Services
logger.LogDebug("[{Operation}] ffmpeg started (PID: {ProcessId}) in {WorkingDirectory}", operationName, process.Id, workingDirectory);
var outputTask = process.StandardOutput.ReadToEndAsync(cancellationToken);
var errorTask = process.StandardError.ReadToEndAsync(cancellationToken);
if (inputStream.CanSeek)
inputStream.Position = 0;
await inputStream.CopyToAsync(process.StandardInput.BaseStream, cancellationToken);
process.StandardInput.Close();
return await WaitForProcessResultAsync(process, operationName, cancellationToken);
return await WaitForProcessResultAsync(process, outputTask, errorTask, operationName, cancellationToken);
}
async Task<FfmpegExecutionResult> ExecuteFfmpegAsync(
@@ -123,7 +126,10 @@ namespace Musify.Infrastructure.Services
logger.LogDebug("[{Operation}] ffmpeg started (PID: {ProcessId}) in {WorkingDirectory}", operationName, process.Id, workingDirectory);
return await WaitForProcessResultAsync(process, operationName, cancellationToken);
var outputTask = process.StandardOutput.ReadToEndAsync(cancellationToken);
var errorTask = process.StandardError.ReadToEndAsync(cancellationToken);
return await WaitForProcessResultAsync(process, outputTask, errorTask, operationName, cancellationToken);
}
Process BuildProcess(string arguments, string workingDirectory, bool redirectStandardInput)
@@ -144,12 +150,11 @@ namespace Musify.Infrastructure.Services
async Task<FfmpegExecutionResult> WaitForProcessResultAsync(
Process process,
Task<string> outputTask,
Task<string> errorTask,
string operationName,
CancellationToken cancellationToken)
{
var errorTask = process.StandardError.ReadToEndAsync(cancellationToken);
var outputTask = process.StandardOutput.ReadToEndAsync(cancellationToken);
using var linkedCancellationTokens = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
linkedCancellationTokens.CancelAfter(audioTranscoderConfiguration.TranscodingTimeout);
backend/Musify.Infrastructure/Services/ServicesDependencyInjection.cs
+1 -1
View File
@@ -21,7 +21,7 @@ namespace Musify.Infrastructure.Services
serviceDescriptors.AddSingleton(serviceProvider =>
serviceProvider.GetRequiredService<IOptions<InfrastructureStorageConfiguration>>().Value);
serviceDescriptors.AddScoped<IAmazonS3>(serviceProvider =>
serviceDescriptors.AddSingleton<IAmazonS3>(serviceProvider =>
{
var configuration = serviceProvider.GetRequiredService<InfrastructureStorageConfiguration>();
var s3Configuration = new AmazonS3Config