Split AlbumApplicationResponse into a Local/External hierarchy

AlbumApplicationResponse used to carry YouTubeAlbumId/ThumbnailUrl as two always-present-but-usually-null fields for the sake of a single flat shape. Since one of these fields IS genuinely exclusive to external albums, an inheritance split reads better than the flattened shape: AlbumApplicationResponse now holds only the fields shared by every album, and ExternalAlbumApplicationResponse adds ExternalId (renamed from YouTubeAlbumId, matching the source-generalized naming used everywhere else) and ThumbnailUrl. [JsonPolymorphic]/[JsonDerivedType] are required here, not optional: without them System.Text.Json serializes strictly by the declared CLR type at each call site (both the bare return type and nested inside AlbumSearchItemResponse.Album), so an ExternalAlbumApplicationResponse instance would silently lose its extra fields on the wire. This also gives every response a "source" discriminator field for free, consistent with AlbumSearchItemResponse.Source, and the generated OpenAPI schema now models it as a proper oneOf/discriminator instead of nullable fields.
2026-09-10 19:19:31 +02:00
parent 478b90d75c
commit 7ae6c0a7a2
4 changed files with 71 additions and 24 deletions
@@ -14,7 +14,7 @@ namespace Musify.Application.Albums.Responses
        YouTubeAlbumResult? YouTubeAlbum)
    {
        public static AlbumSearchItemResponse FromAlbum(AlbumApplicationResponse album) =>
-            new(album.YouTubeAlbumId is not null ? TrackSource.YouTube : TrackSource.Local, album, null);
+            new(album is ExternalAlbumApplicationResponse ? TrackSource.YouTube : TrackSource.Local, album, null);

        public static AlbumSearchItemResponse FromYouTubeAlbum(YouTubeAlbumResult album) =>
            new(TrackSource.YouTube, null, album);