From 877f2c42a4fbcbfddd004c715839c513d1e7706d Mon Sep 17 00:00:00 2001 From: XShine555 Date: Tue, 14 Jul 2026 13:54:08 +0200 Subject: [PATCH] refactor(backend): rename AudioTranscoderConfiguration/Service to AudioConfiguration/AudioService --- ...rConfiguration.cs => AudioConfiguration.cs} | 2 +- .../Services/AudioTranscoderService.cs | 18 +++++++++--------- .../Services/ServicesDependencyInjection.cs | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) rename backend/Musify.Infrastructure/Configuration/{AudioTranscoderConfiguration.cs => AudioConfiguration.cs} (95%) diff --git a/backend/Musify.Infrastructure/Configuration/AudioTranscoderConfiguration.cs b/backend/Musify.Infrastructure/Configuration/AudioConfiguration.cs similarity index 95% rename from backend/Musify.Infrastructure/Configuration/AudioTranscoderConfiguration.cs rename to backend/Musify.Infrastructure/Configuration/AudioConfiguration.cs index 7bf532c..b1cb2a9 100644 --- a/backend/Musify.Infrastructure/Configuration/AudioTranscoderConfiguration.cs +++ b/backend/Musify.Infrastructure/Configuration/AudioConfiguration.cs @@ -2,7 +2,7 @@ namespace Musify.Infrastructure.Configuration { - public class AudioTranscoderConfiguration + public class AudioConfiguration { public const string SectionName = "AudioTranscoder"; diff --git a/backend/Musify.Infrastructure/Services/AudioTranscoderService.cs b/backend/Musify.Infrastructure/Services/AudioTranscoderService.cs index f22991c..dfe75e0 100644 --- a/backend/Musify.Infrastructure/Services/AudioTranscoderService.cs +++ b/backend/Musify.Infrastructure/Services/AudioTranscoderService.cs @@ -7,8 +7,8 @@ using System.Text.RegularExpressions; namespace Musify.Infrastructure.Services { - public partial class AudioTranscoderService(ILogger logger, - AudioTranscoderConfiguration audioTranscoderConfiguration) + public partial class AudioService(ILogger logger, + AudioConfiguration audioConfiguration) : IAudioTranscoderService { record FfmpegExecutionResult(int ExitCode, string StandardOutput, string StandardError); @@ -25,7 +25,7 @@ namespace Musify.Infrastructure.Services logger.LogInformation("Starting audio transcoding for {DestinationPath}", destinationPath); var executionResult = await ExecuteFfmpegWithInputAsync( - BuildAudioFileArguments(destinationPath, audioTranscoderConfiguration.Ffmpeg), + BuildAudioFileArguments(destinationPath, audioConfiguration.Ffmpeg), destinationPath, audioStream, "TranscodeToAudioFile", @@ -40,13 +40,13 @@ namespace Musify.Infrastructure.Services logger.LogInformation("Audio transcoding completed for {DestinationPath}", destinationPath); - var outputPath = Path.Combine(destinationPath, audioTranscoderConfiguration.Ffmpeg.OutputFileName); + var outputPath = Path.Combine(destinationPath, audioConfiguration.Ffmpeg.OutputFileName); var duration = await GetAudioDurationAsync(outputPath, cancellationToken); return new AudioTranscodeResult(executionResult.ExitCode, duration); } catch (TimeoutException timeoutException) { - logger.LogError(timeoutException, "Audio transcoding timed out after {Timeout} for {DestinationPath}", audioTranscoderConfiguration.TranscodingTimeout, destinationPath); + logger.LogError(timeoutException, "Audio transcoding timed out after {Timeout} for {DestinationPath}", audioConfiguration.TranscodingTimeout, destinationPath); throw; } catch (Exception exception) @@ -162,7 +162,7 @@ namespace Musify.Infrastructure.Services { StartInfo = new ProcessStartInfo { - FileName = audioTranscoderConfiguration.Ffmpeg.ExecutableName, + FileName = audioConfiguration.Ffmpeg.ExecutableName, WorkingDirectory = workingDirectory, Arguments = arguments, RedirectStandardInput = redirectStandardInput, @@ -181,7 +181,7 @@ namespace Musify.Infrastructure.Services CancellationToken cancellationToken) { using var linkedCancellationTokens = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken); - linkedCancellationTokens.CancelAfter(audioTranscoderConfiguration.TranscodingTimeout); + linkedCancellationTokens.CancelAfter(audioConfiguration.TranscodingTimeout); try { @@ -190,10 +190,10 @@ namespace Musify.Infrastructure.Services catch (OperationCanceledException) when (!cancellationToken.IsCancellationRequested) { logger.LogError("[{Operation}] ffmpeg timed out after {Timeout} (PID: {ProcessId} )", - operationName, audioTranscoderConfiguration.TranscodingTimeout, process.Id); + operationName, audioConfiguration.TranscodingTimeout, process.Id); TryKillProcess(process); - throw new TimeoutException($"ffmpeg execution exceeded timeout {audioTranscoderConfiguration.TranscodingTimeout}."); + throw new TimeoutException($"ffmpeg execution exceeded timeout {audioConfiguration.TranscodingTimeout}."); } var standardError = await errorTask; diff --git a/backend/Musify.Infrastructure/Services/ServicesDependencyInjection.cs b/backend/Musify.Infrastructure/Services/ServicesDependencyInjection.cs index ae79471..af27b96 100644 --- a/backend/Musify.Infrastructure/Services/ServicesDependencyInjection.cs +++ b/backend/Musify.Infrastructure/Services/ServicesDependencyInjection.cs @@ -77,14 +77,14 @@ namespace Musify.Infrastructure.Services public static IServiceCollection AddAudioTranscoder(this IServiceCollection serviceDescriptors, IConfiguration configuration) { serviceDescriptors - .AddOptionsWithValidateOnStart() - .Bind(configuration.GetRequiredSection(AudioTranscoderConfiguration.SectionName)) + .AddOptionsWithValidateOnStart() + .Bind(configuration.GetRequiredSection(AudioConfiguration.SectionName)) .ValidateDataAnnotations(); serviceDescriptors.AddSingleton(serviceProvider => - serviceProvider.GetRequiredService>().Value); + serviceProvider.GetRequiredService>().Value); - serviceDescriptors.AddScoped(); + serviceDescriptors.AddScoped(); return serviceDescriptors; } }