From 8be0f8656077aefa2bfb31a29a8f9a2dba1b0b10 Mon Sep 17 00:00:00 2001 From: XShine555 Date: Fri, 20 Mar 2026 23:24:32 +0100 Subject: [PATCH] Nullable --- Domain/Entities/ProcessExecution.cs | 4 ++-- Domain/Entities/ProcessStepExecution.cs | 4 ++-- Infrastructure/Storage/StorageHandler.cs | 16 ++++++++-------- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Domain/Entities/ProcessExecution.cs b/Domain/Entities/ProcessExecution.cs index b0bbf21..cc6df6f 100644 --- a/Domain/Entities/ProcessExecution.cs +++ b/Domain/Entities/ProcessExecution.cs @@ -26,10 +26,10 @@ namespace Musify.Domain.Entities [Required] public DateTime StartedDateTime { get; set; } = DateTime.UtcNow; - public DateTime FinishedDateTime { get; set; } + public DateTime? FinishedDateTime { get; set; } [MaxLength(2048)] - public string ErrorMessage { get; set; } + public string? ErrorMessage { get; set; } public ICollection Steps { get; set; } = new List(); } diff --git a/Domain/Entities/ProcessStepExecution.cs b/Domain/Entities/ProcessStepExecution.cs index a1d01cc..0847ecf 100644 --- a/Domain/Entities/ProcessStepExecution.cs +++ b/Domain/Entities/ProcessStepExecution.cs @@ -29,10 +29,10 @@ namespace Musify.Domain.Entities [Required] public DateTime StartedDateTime { get; set; } = DateTime.UtcNow; - public DateTime FinishedDateTime { get; set; } + public DateTime? FinishedDateTime { get; set; } [MaxLength(2048)] - public string ErrorMessage { get; set; } + public string? ErrorMessage { get; set; } [ForeignKey(nameof(ProcessExecutionId)) ] public ProcessExecution ProcessExecution { get; set; } diff --git a/Infrastructure/Storage/StorageHandler.cs b/Infrastructure/Storage/StorageHandler.cs index edacf15..1968b9f 100644 --- a/Infrastructure/Storage/StorageHandler.cs +++ b/Infrastructure/Storage/StorageHandler.cs @@ -29,9 +29,9 @@ namespace Musify.Infrastructure.Storage logger.LogDebug("Successfully got file from S3 with bucket name {BucketName} and key name {KeyName}", bucketName, keyName); return Result.Success(response.ResponseStream); } - catch + catch (Exception exception) { - logger.LogDebug("Failed to get file from S3 with bucket name {BucketName} and key name {KeyName}", bucketName, keyName); + logger.LogDebug(exception, "Failed to get file from S3 with bucket name {BucketName} and key name {KeyName}", bucketName, keyName); return Result.NotFound(); } } @@ -92,9 +92,9 @@ namespace Musify.Infrastructure.Storage upload.State = UploadState.Successful; logger.LogInformation("Successfully transferred file {FileName} to S3 with bucket name {BucketName} and route {Route}", fileName, bucketName, route); } - catch + catch (Exception exception) { - logger.LogError("Failed to transfer file {FileName} to S3 with bucket name {BucketName} and route {Route}", fileName, bucketName, route); + logger.LogError(exception, "Failed to transfer file {FileName} to S3 with bucket name {BucketName} and route {Route}", fileName, bucketName, route); upload.State = UploadState.Failed; } } @@ -129,9 +129,9 @@ namespace Musify.Infrastructure.Storage var response = await amazonS3.PutObjectAsync(request, cancellationToken); logger.LogInformation("Successfully uploaded file to S3 with bucket name {BucketName} and key name {KeyName}", bucketName, keyName); } - catch + catch (Exception exception) { - logger.LogError("Failed to upload file to S3 with bucket name {BucketName} and key name {KeyName}", bucketName, keyName); + logger.LogError(exception, "Failed to upload file to S3 with bucket name {BucketName} and key name {KeyName}", bucketName, keyName); upload.State = UploadState.Failed; return Result.Error($"Failed to upload file to S3 with bucket name {bucketName} and key name {keyName}"); } @@ -161,9 +161,9 @@ namespace Musify.Infrastructure.Storage sourceBucketName, sourceKeyName, destinationBucketName, destinationKeyName); return Result.Success(); } - catch + catch (Exception exception) { - logger.LogError("Failed to copy file from S3 with bucket name {SourceBucketName} and key name {SourceKeyName} to bucket name {DestinationBucketName} and key name {DestinationKeyName}", + logger.LogError(exception, "Failed to copy file from S3 with bucket name {SourceBucketName} and key name {SourceKeyName} to bucket name {DestinationBucketName} and key name {DestinationKeyName}", sourceBucketName, sourceKeyName, destinationBucketName, destinationKeyName); return Result.Error($"Failed to copy file from S3 with bucket name {sourceBucketName} and key name {sourceKeyName} to bucket name {destinationBucketName} and key name {destinationKeyName}"); }