Remove no-op playlist picture migration; cover picture-add transition in tests

The Sept migration MakePlayListPictureColumnsOptional altered the PlayLists picture columns to nullable:true when they were already nullable:true (set back in MakePlayListPicturesNullable, two months earlier) — a dead migration left over from making the Pictures navigation itself optional, which produces no actual schema change. Verified with `dotnet ef migrations has-pending-model-changes` and a full migration run against a fresh Postgres container that removing it introduces no drift. Also add a test for updating a playlist that has no picture yet, which was the one Pictures-related state transition without coverage.
2026-09-20 22:40:40 +02:00
parent 58eb670fed
commit a4ca1f32d3
4 changed files with 55 additions and 1296 deletions
@@ -107,5 +107,30 @@ namespace Musify.Application.Tests.PlayLists
            Assert.Equal("Original Name", result.Value.Name);
            Assert.Equal("Original description", result.Value.Description);
        }
+
+        [Fact]
+        public async Task Handle_PlayListWithoutPictures_ValidPictureIntent_SetsPictureAndPublishesSourceEvent()
+        {
+            storageService
+                .HeadObjectAsync(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<CancellationToken>())
+                .Returns(new ObjectMetaData("image/webp", 1024));
+
+            var owner = TestEntities.User();
+            var playList = TestEntities.PlayList(owner.Id);
+            playList.Pictures = null;
+            var intent = TestEntities.UploadIntent(owner.Id, Musify.Domain.ValueObjects.UploadIntentPurpose.PlayListPicture, objectName: "new-cover.webp");
+            await SeedAsync(owner, playList, intent);
+
+            var command = new UpdatePlayListCommand(owner.Id, playList.Id, null, null, intent.Id);
+
+            var result = await CreateHandler().Handle(command, TestContext.Current.CancellationToken);
+
+            Assert.False(result.IsError);
+            Assert.Equal("new-cover.webp", result.Value.SmallImageKeyName);
+            var stored = await Database.PlayLists.FindAsync([playList.Id], TestContext.Current.CancellationToken);
+            Assert.NotNull(stored);
+            Assert.Equal("new-cover.webp", stored.Pictures?.OriginalName);
+            await eventBus.Received(1).PublishAsync(Arg.Any<Musify.Application.Events.UpdatePlayListPictureSourceEvent>(), Arg.Any<CancellationToken>());
+        }
    }
 }