NotS1mp/Musify
0
0
Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Use block-scoped namespaces in the test suite

Browse Source 
Converts all 73 test source files from file-scoped (namespace X;) to
block-scoped (namespace X { ... }) declarations, re-indenting their
contents accordingly. Matches the existing convention already used in
several production files (e.g. Musify.Infrastructure.Configuration,
Musify.Application.Contracts).

Mechanical change only, done with a script, verified with a full
rebuild (0 warnings, 0 errors) and test run (257/257 passing).
This commit is contained in:
Admin
2026-09-09 23:09:43 +02:00
parent 56e06ccd5f
commit b5700614c1
73 changed files with 3718 additions and 3645 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/Tests/Musify.Application.Tests/Shared/StorageKeyTests.cs
+28 -27
View File
@@ -1,40 +1,41 @@
using Musify.Application.Shared;
using Xunit;
namespace Musify.Application.Tests.Shared;
public sealed class StorageKeyTests
namespace Musify.Application.Tests.Shared
{
[Fact]
public void Combine_MultipleSegments_JoinsThemWithForwardSlashes()
public sealed class StorageKeyTests
{
var key = StorageKey.Combine("Tracks", "SmallPictures", "cover.webp");
[Fact]
public void Combine_MultipleSegments_JoinsThemWithForwardSlashes()
{
var key = StorageKey.Combine("Tracks", "SmallPictures", "cover.webp");
Assert.Equal("Tracks/SmallPictures/cover.webp", key);
}
Assert.Equal("Tracks/SmallPictures/cover.webp", key);
}
[Fact]
public void Combine_SegmentsWithSurroundingSlashesAndWhitespace_TrimsThem()
{
var key = StorageKey.Combine(" Tracks/ ", "/SmallPictures/", "cover.webp");
[Fact]
public void Combine_SegmentsWithSurroundingSlashesAndWhitespace_TrimsThem()
{
var key = StorageKey.Combine(" Tracks/ ", "/SmallPictures/", "cover.webp");
Assert.Equal("Tracks/SmallPictures/cover.webp", key);
}
Assert.Equal("Tracks/SmallPictures/cover.webp", key);
}
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData(" ")]
public void Combine_BlankSegment_IsSkipped(string? blank)
{
var key = StorageKey.Combine("Tracks", blank!, "cover.webp");
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData(" ")]
public void Combine_BlankSegment_IsSkipped(string? blank)
{
var key = StorageKey.Combine("Tracks", blank!, "cover.webp");
Assert.Equal("Tracks/cover.webp", key);
}
Assert.Equal("Tracks/cover.webp", key);
}
[Fact]
public void Combine_NoSegments_ReturnsEmptyString()
{
Assert.Equal(string.Empty, StorageKey.Combine());
[Fact]
public void Combine_NoSegments_ReturnsEmptyString()
{
Assert.Equal(string.Empty, StorageKey.Combine());
}
}
}
backend/Tests/Musify.Application.Tests/Shared/TrackApplicationResponseTests.cs
+35 -34
View File
@@ -4,49 +4,50 @@ using Musify.Domain.Entities;
using Musify.Domain.ValueObjects;
using Xunit;
namespace Musify.Application.Tests.Shared;
public sealed class TrackApplicationResponseTests
namespace Musify.Application.Tests.Shared
{
[Fact]
public void FromEntity_LocalTrack_UsesOwnerNameAsArtist()
public sealed class TrackApplicationResponseTests
{
var owner = TestEntities.User(1, "The Owner");
var track = TestEntities.LocalTrack(owner);
[Fact]
public void FromEntity_LocalTrack_UsesOwnerNameAsArtist()
{
var owner = TestEntities.User(1, "The Owner");
var track = TestEntities.LocalTrack(owner);
var response = TrackApplicationResponse.FromEntity(track, listensCount: 3);
var response = TrackApplicationResponse.FromEntity(track, listensCount: 3);
Assert.Equal("The Owner", response.Artist);
Assert.Equal(TrackSource.Local, response.Source);
Assert.Equal(owner.Id, response.OwnerUserId);
Assert.Equal(3, response.ListensCount);
}
Assert.Equal("The Owner", response.Artist);
Assert.Equal(TrackSource.Local, response.Source);
Assert.Equal(owner.Id, response.OwnerUserId);
Assert.Equal(3, response.ListensCount);
}
[Fact]
public void FromEntity_ExternalTrackWithArtists_JoinsThemInPositionOrder()
{
var track = TestEntities.ExternalTrack();
var second = new Artist { Name = "Second Artist", NormalizedName = "SECOND ARTIST", ExternalId = "second" };
var first = new Artist { Name = "First Artist", NormalizedName = "FIRST ARTIST", ExternalId = "first" };
track.TrackArtists =
[
new TrackArtist { TrackId = track.Id, ArtistId = second.Id, Position = 1, Artist = second, Track = track },
new TrackArtist { TrackId = track.Id, ArtistId = first.Id, Position = 0, Artist = first, Track = track }
];
[Fact]
public void FromEntity_ExternalTrackWithArtists_JoinsThemInPositionOrder()
{
var track = TestEntities.ExternalTrack();
var second = new Artist { Name = "Second Artist", NormalizedName = "SECOND ARTIST", ExternalId = "second" };
var first = new Artist { Name = "First Artist", NormalizedName = "FIRST ARTIST", ExternalId = "first" };
track.TrackArtists =
[
new TrackArtist { TrackId = track.Id, ArtistId = second.Id, Position = 1, Artist = second, Track = track },
new TrackArtist { TrackId = track.Id, ArtistId = first.Id, Position = 0, Artist = first, Track = track }
];
var response = TrackApplicationResponse.FromEntity(track, listensCount: 0);
var response = TrackApplicationResponse.FromEntity(track, listensCount: 0);
Assert.Equal("First Artist, Second Artist", response.Artist);
Assert.Equal(track.ExternalId, response.ExternalId);
}
Assert.Equal("First Artist, Second Artist", response.Artist);
Assert.Equal(track.ExternalId, response.ExternalId);
}
[Fact]
public void FromEntity_ExternalTrackWithNoArtists_HasNullArtist()
{
var track = TestEntities.ExternalTrack();
[Fact]
public void FromEntity_ExternalTrackWithNoArtists_HasNullArtist()
{
var track = TestEntities.ExternalTrack();
var response = TrackApplicationResponse.FromEntity(track, listensCount: 0);
var response = TrackApplicationResponse.FromEntity(track, listensCount: 0);
Assert.Null(response.Artist);
Assert.Null(response.Artist);
}
}
}