Use block-scoped namespaces in the test suite

Converts all 73 test source files from file-scoped (namespace X;) to
block-scoped (namespace X { ... }) declarations, re-indenting their
contents accordingly. Matches the existing convention already used in
several production files (e.g. Musify.Infrastructure.Configuration,
Musify.Application.Contracts).

Mechanical change only, done with a script, verified with a full
rebuild (0 warnings, 0 errors) and test run (257/257 passing).
This commit is contained in:
2026-09-09 23:09:43 +02:00
parent 56e06ccd5f
commit b5700614c1
73 changed files with 3718 additions and 3645 deletions
@@ -6,141 +6,142 @@ using Musify.StreamingGateway.Authentication;
using Musify.StreamingGateway.Configuration;
using Xunit;
namespace Musify.StreamingGateway.Tests.Authentication;
public sealed class TicketValidatorTests : IDisposable
namespace Musify.StreamingGateway.Tests.Authentication
{
private const string Issuer = "musify-webapi";
private const string Audience = "media-gateway";
private readonly string publicKeyPath = Path.GetTempFileName();
private readonly RSA rsa = RSA.Create(2048);
private readonly JsonWebTokenHandler tokenHandler = new();
public TicketValidatorTests() => File.WriteAllText(publicKeyPath, rsa.ExportSubjectPublicKeyInfoPem());
public void Dispose()
public sealed class TicketValidatorTests : IDisposable
{
rsa.Dispose();
File.Delete(publicKeyPath);
}
private const string Issuer = "musify-webapi";
private const string Audience = "media-gateway";
private TicketValidator CreateValidator() => new(Options.Create(new StreamTicketValidationOptions
{
PublicKeyPath = publicKeyPath,
Audience = Audience,
Issuer = Issuer
}));
private readonly string publicKeyPath = Path.GetTempFileName();
private readonly RSA rsa = RSA.Create(2048);
private readonly JsonWebTokenHandler tokenHandler = new();
private string IssueToken(string prefix = "Tracks/ProcessedAudios/abc/", string issuer = Issuer, string audience = Audience,
DateTime? expires = null, DateTime? notBefore = null)
{
var descriptor = new SecurityTokenDescriptor
public TicketValidatorTests() => File.WriteAllText(publicKeyPath, rsa.ExportSubjectPublicKeyInfoPem());
public void Dispose()
{
Issuer = issuer,
Audience = audience,
NotBefore = notBefore ?? DateTime.UtcNow.AddMinutes(-1),
Expires = expires ?? DateTime.UtcNow.AddMinutes(5),
Claims = new Dictionary<string, object> { ["prefix"] = prefix },
SigningCredentials = new SigningCredentials(new RsaSecurityKey(rsa), SecurityAlgorithms.RsaSha256),
};
return tokenHandler.CreateToken(descriptor);
}
rsa.Dispose();
File.Delete(publicKeyPath);
}
[Fact]
public async Task ValidateTicketAsync_ValidToken_ReturnsThePrefixClaim()
{
var token = IssueToken(prefix: "Tracks/ProcessedAudios/xyz/");
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal("Tracks/ProcessedAudios/xyz/", prefix);
}
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData(" ")]
public async Task ValidateTicketAsync_BlankToken_ReturnsEmptyString(string? token)
{
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_MalformedToken_ReturnsEmptyString()
{
var prefix = await CreateValidator().ValidateTicketAsync("not-a-real-jwt");
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_ExpiredToken_ReturnsEmptyString()
{
var token = IssueToken(expires: DateTime.UtcNow.AddMinutes(-40), notBefore: DateTime.UtcNow.AddMinutes(-50));
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_WrongIssuer_ReturnsEmptyString()
{
var token = IssueToken(issuer: "someone-else");
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_WrongAudience_ReturnsEmptyString()
{
var token = IssueToken(audience: "someone-else");
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_SignedWithADifferentKey_ReturnsEmptyString()
{
using var otherKey = RSA.Create(2048);
var descriptor = new SecurityTokenDescriptor
private TicketValidator CreateValidator() => new(Options.Create(new StreamTicketValidationOptions
{
Issuer = Issuer,
PublicKeyPath = publicKeyPath,
Audience = Audience,
NotBefore = DateTime.UtcNow.AddMinutes(-1),
Expires = DateTime.UtcNow.AddMinutes(5),
Claims = new Dictionary<string, object> { ["prefix"] = "Tracks/ProcessedAudios/abc/" },
SigningCredentials = new SigningCredentials(new RsaSecurityKey(otherKey), SecurityAlgorithms.RsaSha256),
};
var token = tokenHandler.CreateToken(descriptor);
Issuer = Issuer
}));
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_MissingPrefixClaim_ReturnsEmptyString()
{
var descriptor = new SecurityTokenDescriptor
private string IssueToken(string prefix = "Tracks/ProcessedAudios/abc/", string issuer = Issuer, string audience = Audience,
DateTime? expires = null, DateTime? notBefore = null)
{
Issuer = Issuer,
Audience = Audience,
NotBefore = DateTime.UtcNow.AddMinutes(-1),
Expires = DateTime.UtcNow.AddMinutes(5),
SigningCredentials = new SigningCredentials(new RsaSecurityKey(rsa), SecurityAlgorithms.RsaSha256),
};
var token = tokenHandler.CreateToken(descriptor);
var descriptor = new SecurityTokenDescriptor
{
Issuer = issuer,
Audience = audience,
NotBefore = notBefore ?? DateTime.UtcNow.AddMinutes(-1),
Expires = expires ?? DateTime.UtcNow.AddMinutes(5),
Claims = new Dictionary<string, object> { ["prefix"] = prefix },
SigningCredentials = new SigningCredentials(new RsaSecurityKey(rsa), SecurityAlgorithms.RsaSha256),
};
return tokenHandler.CreateToken(descriptor);
}
var prefix = await CreateValidator().ValidateTicketAsync(token);
[Fact]
public async Task ValidateTicketAsync_ValidToken_ReturnsThePrefixClaim()
{
var token = IssueToken(prefix: "Tracks/ProcessedAudios/xyz/");
Assert.Equal(string.Empty, prefix);
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal("Tracks/ProcessedAudios/xyz/", prefix);
}
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData(" ")]
public async Task ValidateTicketAsync_BlankToken_ReturnsEmptyString(string? token)
{
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_MalformedToken_ReturnsEmptyString()
{
var prefix = await CreateValidator().ValidateTicketAsync("not-a-real-jwt");
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_ExpiredToken_ReturnsEmptyString()
{
var token = IssueToken(expires: DateTime.UtcNow.AddMinutes(-40), notBefore: DateTime.UtcNow.AddMinutes(-50));
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_WrongIssuer_ReturnsEmptyString()
{
var token = IssueToken(issuer: "someone-else");
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_WrongAudience_ReturnsEmptyString()
{
var token = IssueToken(audience: "someone-else");
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_SignedWithADifferentKey_ReturnsEmptyString()
{
using var otherKey = RSA.Create(2048);
var descriptor = new SecurityTokenDescriptor
{
Issuer = Issuer,
Audience = Audience,
NotBefore = DateTime.UtcNow.AddMinutes(-1),
Expires = DateTime.UtcNow.AddMinutes(5),
Claims = new Dictionary<string, object> { ["prefix"] = "Tracks/ProcessedAudios/abc/" },
SigningCredentials = new SigningCredentials(new RsaSecurityKey(otherKey), SecurityAlgorithms.RsaSha256),
};
var token = tokenHandler.CreateToken(descriptor);
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
[Fact]
public async Task ValidateTicketAsync_MissingPrefixClaim_ReturnsEmptyString()
{
var descriptor = new SecurityTokenDescriptor
{
Issuer = Issuer,
Audience = Audience,
NotBefore = DateTime.UtcNow.AddMinutes(-1),
Expires = DateTime.UtcNow.AddMinutes(5),
SigningCredentials = new SigningCredentials(new RsaSecurityKey(rsa), SecurityAlgorithms.RsaSha256),
};
var token = tokenHandler.CreateToken(descriptor);
var prefix = await CreateValidator().ValidateTicketAsync(token);
Assert.Equal(string.Empty, prefix);
}
}
}