Fix test bad practices and tighten weak assertions

- StorageServiceTests: replace out-param + manual dispose with IAsyncLifetime
- PictureServiceTests: Assert.True bound checks -> Assert.InRange
- CreateAlbumCommandHandlerTests: assert the specific NotFound error type
  instead of just IsError, matching what the test name promises
- CreateAlbumRequestValidatorTests: replace a boundary Theory that computed
  its expected result inline with explicit Facts against the real
  AlbumReleaseYear constants
- Remove unused using directives across a handful of production and test
  files found during the review

Full suite verified green: 250/250 tests passing, 0 build warnings.

This commit is contained in:

Admin

2026-09-09 21:53:00 +02:00

parent a26f4b43fd

commit b57949a6bc

24 changed files with 48 additions and 66 deletions

									
										backend/Tests/Musify.Application.Tests/Tracks/GetTrackCoverQueryHandlerTests.cs
									
		-1
	
												View File
												
				@@ -1,7 +1,6 @@

				using ErrorOr;

				using Musify.Application.Tests.TestSupport;

				using Musify.Application.Tracks;

				using Musify.Domain.ValueObjects;

				using Xunit;

				namespace Musify.Application.Tests.Tracks;