NotS1mp/Musify
0
0
Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases Wiki Activity

Strip comments and dedupe normalized literals in backend tests

Browse Source 
- Remove all // and /// comments from the backend test suite.
- Replace hardcoded normalized-form string literals (e.g. NormalizedTitle/
  NormalizedName duplicating a title/name in upper case) with a variable
  plus .ToUpperInvariant(), so the two values can't drift apart.
This commit is contained in:
Admin
2026-09-10 02:45:11 +02:00
parent 5658dd24ff
commit c418844178
14 changed files with 29 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/Tests/Musify.Infrastructure.Tests/Persistence/DatabaseTests.cs
+23 -15
View File
@@ -14,13 +14,15 @@ namespace Musify.Infrastructure.Tests.Persistence
{
await using var database = fixture.CreateDatabase();
var user = new User { Id = Random.Shared.NextInt64(1, long.MaxValue), Name = "roundtrip-user", NormalizedName = "ROUNDTRIP-USER" };
var userName = "roundtrip-user";
var user = new User { Id = Random.Shared.NextInt64(1, long.MaxValue), Name = userName, NormalizedName = userName.ToUpperInvariant() };
await database.Users.AddAsync(user, TestContext.Current.CancellationToken);
var trackTitle = "Round Trip Track";
var track = new LocalTrack
{
Title = "Round Trip Track",
NormalizedTitle = "ROUND TRIP TRACK",
Title = trackTitle,
NormalizedTitle = trackTitle.ToUpperInvariant(),
DurationSeconds = 123.4,
OwnerUserId = user.Id,
Owner = user,
@@ -34,7 +36,7 @@ namespace Musify.Infrastructure.Tests.Persistence
var stored = await reloaded.Tracks.AsNoTracking().SingleAsync(t => t.Id == track.Id, TestContext.Current.CancellationToken);
Assert.IsType<LocalTrack>(stored);
Assert.Equal("Round Trip Track", stored.Title);
Assert.Equal(trackTitle, stored.Title);
Assert.Equal("cover.webp", stored.Pictures.OriginalName);
Assert.Equal("song.mp3", stored.Audio.OriginalName);
Assert.Equal(user.Id, ((LocalTrack)stored).OwnerUserId);
@@ -60,8 +62,10 @@ namespace Musify.Infrastructure.Tests.Persistence
{
await using var database = fixture.CreateDatabase();
var user = new User { Id = Random.Shared.NextInt64(1, long.MaxValue), Name = "cascade-user", NormalizedName = "CASCADE-USER" };
var album = new UserAlbum { Title = "Cascade Album", NormalizedTitle = "CASCADE ALBUM", OwnerUserId = user.Id };
var userName = "cascade-user";
var user = new User { Id = Random.Shared.NextInt64(1, long.MaxValue), Name = userName, NormalizedName = userName.ToUpperInvariant() };
var albumTitle = "Cascade Album";
var album = new UserAlbum { Title = albumTitle, NormalizedTitle = albumTitle.ToUpperInvariant(), OwnerUserId = user.Id };
var track = BuildExternalTrack($"cascade-{Guid.NewGuid():N}");
var link = new AlbumHasTrack { AlbumId = album.Id, TrackId = track.Id, TrackNumber = 1 };
@@ -78,15 +82,19 @@ namespace Musify.Infrastructure.Tests.Persistence
Assert.True(await verifier.ExternalTracks.AnyAsync(t => t.Id == track.Id, TestContext.Current.CancellationToken));
}
private static ExternalTrack BuildExternalTrack(string externalId) => new()
private static ExternalTrack BuildExternalTrack(string externalId)
{
Title = "External",
NormalizedTitle = "EXTERNAL",
DurationSeconds = 100,
Source = TrackSource.YouTube,
ExternalId = externalId,
Pictures = new TrackPictures(),
Audio = new TrackAudio()
};
var title = "External";
return new ExternalTrack
{
Title = title,
NormalizedTitle = title.ToUpperInvariant(),
DurationSeconds = 100,
Source = TrackSource.YouTube,
ExternalId = externalId,
Pictures = new TrackPictures(),
Audio = new TrackAudio()
};
}
}
}