Add track status filter and counts, album track ids and bulk track deletion
GET /tracks/users/{userId} accepts repeated status values and returns the
albums each track belongs to. GET /tracks/users/{userId}/status-counts,
GET /albums/{id}/tracks/ids and DELETE /tracks with a list of track ids
are new.
This commit is contained in:
@@ -0,0 +1,81 @@
|
||||
using ErrorOr;
|
||||
using Musify.Application.Contracts;
|
||||
using Musify.Application.Events;
|
||||
using Musify.Application.Tests.TestSupport;
|
||||
using Musify.Application.Tracks;
|
||||
using Musify.Domain.ValueObjects;
|
||||
using NSubstitute;
|
||||
using Xunit;
|
||||
|
||||
namespace Musify.Application.Tests.Tracks
|
||||
{
|
||||
public sealed class DeleteTracksCommandHandlerTests : HandlerTestBase
|
||||
{
|
||||
private readonly IEventBus eventBus = Substitute.For<IEventBus>();
|
||||
|
||||
private DeleteTracksCommandHandler CreateHandler() => new(Database, eventBus, NoOpLogger<DeleteTracksCommandHandler>());
|
||||
|
||||
[Fact]
|
||||
public async Task Handle_OwnTracks_MarksAllAsRemovingAndPublishesOneEventEach()
|
||||
{
|
||||
var owner = TestEntities.User();
|
||||
var first = TestEntities.Track(owner, "One");
|
||||
var second = TestEntities.Track(owner, "Two");
|
||||
await SeedAsync(owner, first, second);
|
||||
|
||||
var result = await CreateHandler().Handle(new DeleteTracksCommand(owner.Id, [first.Id, second.Id]), TestContext.Current.CancellationToken);
|
||||
|
||||
Assert.False(result.IsError);
|
||||
Assert.Equal(2, result.Value.DeletedTrackIds.Count);
|
||||
Assert.Empty(result.Value.FailedTrackIds);
|
||||
Assert.All(Database.Tracks.ToList(), track => Assert.Equal(LifeCycleStatus.Removing, track.LifeCycleStatus));
|
||||
await eventBus.Received(2).PublishAsync(Arg.Any<DeleteTrackEvent>(), Arg.Any<CancellationToken>());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handle_TrackOfAnotherUser_ReturnsForbiddenAndDeletesNothing()
|
||||
{
|
||||
var owner = TestEntities.User(1, "owner");
|
||||
var stranger = TestEntities.User(2, "stranger");
|
||||
var mine = TestEntities.Track(owner, "Mine");
|
||||
var theirs = TestEntities.Track(stranger, "Theirs");
|
||||
await SeedAsync(owner, stranger, mine, theirs);
|
||||
|
||||
var result = await CreateHandler().Handle(new DeleteTracksCommand(owner.Id, [mine.Id, theirs.Id]), TestContext.Current.CancellationToken);
|
||||
|
||||
Assert.Equal(ErrorType.Forbidden, result.FirstError.Type);
|
||||
Assert.All(Database.Tracks.ToList(), track => Assert.Equal(LifeCycleStatus.Active, track.LifeCycleStatus));
|
||||
await eventBus.DidNotReceive().PublishAsync(Arg.Any<DeleteTrackEvent>(), Arg.Any<CancellationToken>());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handle_ProcessingAndMissingTracks_AreReturnedAsFailed()
|
||||
{
|
||||
var owner = TestEntities.User();
|
||||
var done = TestEntities.Track(owner, "Done");
|
||||
var busy = TestEntities.Track(owner, "Busy", audio: TestEntities.PendingAudio());
|
||||
var missing = Guid.NewGuid();
|
||||
await SeedAsync(owner, done, busy);
|
||||
|
||||
var result = await CreateHandler().Handle(new DeleteTracksCommand(owner.Id, [done.Id, busy.Id, missing]), TestContext.Current.CancellationToken);
|
||||
|
||||
Assert.False(result.IsError);
|
||||
Assert.Equal([done.Id], result.Value.DeletedTrackIds);
|
||||
Assert.Equal([busy.Id, missing], result.Value.FailedTrackIds);
|
||||
Assert.Equal(LifeCycleStatus.Active, Database.Tracks.Single(t => t.Id == busy.Id).LifeCycleStatus);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handle_DuplicateIds_AreDeletedOnce()
|
||||
{
|
||||
var owner = TestEntities.User();
|
||||
var track = TestEntities.Track(owner);
|
||||
await SeedAsync(owner, track);
|
||||
|
||||
var result = await CreateHandler().Handle(new DeleteTracksCommand(owner.Id, [track.Id, track.Id]), TestContext.Current.CancellationToken);
|
||||
|
||||
Assert.Single(result.Value.DeletedTrackIds);
|
||||
await eventBus.Received(1).PublishAsync(Arg.Any<DeleteTrackEvent>(), Arg.Any<CancellationToken>());
|
||||
}
|
||||
}
|
||||
}
|
||||
+45
@@ -0,0 +1,45 @@
|
||||
using Musify.Application.Tests.TestSupport;
|
||||
using Musify.Application.Tracks;
|
||||
using Musify.Domain.ValueObjects;
|
||||
using Xunit;
|
||||
|
||||
namespace Musify.Application.Tests.Tracks
|
||||
{
|
||||
public sealed class GetTrackStatusCountsQueryHandlerTests : HandlerTestBase
|
||||
{
|
||||
[Fact]
|
||||
public async Task Handle_CountsOnlyActiveTracksOfTheUser()
|
||||
{
|
||||
var owner = TestEntities.User(1, "owner");
|
||||
var other = TestEntities.User(2, "other");
|
||||
await SeedAsync(
|
||||
owner, other,
|
||||
TestEntities.Track(owner, "Done 1"),
|
||||
TestEntities.Track(owner, "Done 2"),
|
||||
TestEntities.Track(owner, "Pending", audio: TestEntities.PendingAudio()),
|
||||
TestEntities.Track(owner, "Processing", audio: new TrackAudio { TranscodeStatus = ProcessingStatus.Processing }),
|
||||
TestEntities.Track(owner, "Failed", audio: new TrackAudio { TranscodeStatus = ProcessingStatus.Failed }),
|
||||
TestEntities.Track(owner, "Removing", lifeCycleStatus: LifeCycleStatus.Removing),
|
||||
TestEntities.Track(other, "Theirs"));
|
||||
|
||||
var counts = await new GetTrackStatusCountsQueryHandler(Database)
|
||||
.Handle(new GetTrackStatusCountsQuery(owner.Id), TestContext.Current.CancellationToken);
|
||||
|
||||
Assert.Equal(5, counts.Total);
|
||||
Assert.Equal(1, counts.Pending);
|
||||
Assert.Equal(1, counts.Processing);
|
||||
Assert.Equal(2, counts.Completed);
|
||||
Assert.Equal(1, counts.Failed);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handle_NoTracks_ReturnsZeros()
|
||||
{
|
||||
var counts = await new GetTrackStatusCountsQueryHandler(Database)
|
||||
.Handle(new GetTrackStatusCountsQuery(99), TestContext.Current.CancellationToken);
|
||||
|
||||
Assert.Equal(0, counts.Total);
|
||||
Assert.Equal(0, counts.Completed);
|
||||
}
|
||||
}
|
||||
}
|
||||
+79
@@ -0,0 +1,79 @@
|
||||
using Musify.Application.Tests.TestSupport;
|
||||
using Musify.Application.Tracks;
|
||||
using Musify.Domain.Entities;
|
||||
using Musify.Domain.ValueObjects;
|
||||
using Xunit;
|
||||
|
||||
namespace Musify.Application.Tests.Tracks
|
||||
{
|
||||
public sealed class GetTracksByUserIdStatusAndAlbumsTests : HandlerTestBase
|
||||
{
|
||||
private GetTracksByUserIdQueryHandler CreateHandler() => new(Database);
|
||||
|
||||
[Fact]
|
||||
public async Task Handle_StatusFilter_ReturnsOnlyMatchingStatuses()
|
||||
{
|
||||
var owner = TestEntities.User();
|
||||
var done = TestEntities.Track(owner, "Done");
|
||||
var pending = TestEntities.Track(owner, "Pending", audio: TestEntities.PendingAudio());
|
||||
var failed = TestEntities.Track(owner, "Failed", audio: new TrackAudio { TranscodeStatus = ProcessingStatus.Failed });
|
||||
await SeedAsync(owner, done, pending, failed);
|
||||
|
||||
var result = await CreateHandler().Handle(
|
||||
new GetTracksByUserIdQuery(owner.Id, null, 1, 10, [ProcessingStatus.Pending, ProcessingStatus.Failed]),
|
||||
TestContext.Current.CancellationToken);
|
||||
|
||||
Assert.False(result.IsError);
|
||||
Assert.Equal(["Failed", "Pending"], result.Value.Items.Select(t => t.Title).Order().ToList());
|
||||
Assert.Equal(2, result.Value.TotalItemCount);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handle_NoStatusFilter_ReturnsEveryStatus()
|
||||
{
|
||||
var owner = TestEntities.User();
|
||||
await SeedAsync(owner, TestEntities.Track(owner, "A"), TestEntities.Track(owner, "B", audio: TestEntities.PendingAudio()));
|
||||
|
||||
var result = await CreateHandler().Handle(new GetTracksByUserIdQuery(owner.Id, null, 1, 10), TestContext.Current.CancellationToken);
|
||||
|
||||
Assert.Equal(2, result.Value.TotalItemCount);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handle_ListsActiveAlbumsOfEachTrack()
|
||||
{
|
||||
var owner = TestEntities.User();
|
||||
var track = TestEntities.Track(owner, "Song");
|
||||
var loose = TestEntities.Track(owner, "Loose");
|
||||
var first = TestEntities.Album(owner.Id, "First");
|
||||
var second = TestEntities.Album(owner.Id, "Second");
|
||||
var removed = TestEntities.Album(owner.Id, "Gone");
|
||||
removed.LifeCycleStatus = LifeCycleStatus.Removing;
|
||||
await SeedAsync(
|
||||
owner, track, loose, first, second, removed,
|
||||
new AlbumHasTrack { AlbumId = first.Id, TrackId = track.Id },
|
||||
new AlbumHasTrack { AlbumId = second.Id, TrackId = track.Id },
|
||||
new AlbumHasTrack { AlbumId = removed.Id, TrackId = track.Id });
|
||||
|
||||
var result = await CreateHandler().Handle(new GetTracksByUserIdQuery(owner.Id, null, 1, 10), TestContext.Current.CancellationToken);
|
||||
|
||||
var song = result.Value.Items.Single(t => t.Title == "Song");
|
||||
Assert.Equal(["First", "Second"], song.Albums.Select(a => a.Title).Order().ToList());
|
||||
Assert.Contains(song.Albums, a => a.Id == first.Id);
|
||||
Assert.Empty(result.Value.Items.Single(t => t.Title == "Loose").Albums);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handle_Paginates()
|
||||
{
|
||||
var owner = TestEntities.User();
|
||||
await SeedAsync(owner, TestEntities.Track(owner, "A"), TestEntities.Track(owner, "B"), TestEntities.Track(owner, "C"));
|
||||
|
||||
var result = await CreateHandler().Handle(new GetTracksByUserIdQuery(owner.Id, null, 2, 2), TestContext.Current.CancellationToken);
|
||||
|
||||
Assert.Single(result.Value.Items);
|
||||
Assert.Equal(3, result.Value.TotalItemCount);
|
||||
Assert.True(result.Value.HasPreviousPage);
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user