Safe code and changes

Application/Users/Handlers/CreateUserCommandHandler.cs

@@ -21,8 +21,17 @@ namespace Musify.Application.Users.Handlers
             }
 
             var newUser = CreateUserCommand.ToEntity(request);
-            await database.Users.AddAsync(newUser, cancellationToken);
-            await database.SaveChangesAsync(cancellationToken);
+
+            try
+            {
+                await database.Users.AddAsync(newUser, cancellationToken);
+                await database.SaveChangesAsync(cancellationToken);
+            }
+            catch (Exception exception)
+            {
+                logger.LogError(exception, "Failed to create user {UserId}", request.Id);
+                return Result.Error($"Failed to create user {request.Id}");
+            }
 
             logger.LogInformation("Created user {UserId}", newUser.Id);
             return Result.Created(UserResponse.FromEntity(newUser));

Application/Users/Handlers/GetUsersQueryHandler.cs

@@ -6,7 +6,6 @@ using Musify.Application.Contracts.Infrastructure;
 using Musify.Application.Users.Queries;
 using Musify.Application.Users.Responses;
 using X.PagedList.EF;
-using X.PagedList.Extensions;
 
 namespace Musify.Application.Users.Handlers
 {
@@ -17,12 +16,12 @@ namespace Musify.Application.Users.Handlers
         {
             var pageNumber = request.PageNumber < 1 ? 1 : request.PageNumber;
             var pageSize = request.PageSize < 1 ? 10 : request.PageSize;
-            var first = (pageNumber - 1) * pageSize;
 
             var user = database.Users
                 .AsNoTracking()
                 .AsQueryable();
-            if (!string.IsNullOrEmpty(request.UsernameSearch))
+
+            if (request.UsernameSearch is not null)
             {
                 var normalizedUsername = request.UsernameSearch.Trim().ToUpperInvariant();
                 user = user.Where(u => u.NormalizedName.Contains(normalizedUsername));