2 Commits

Include renames

Author	SHA1	Message	Date
Admin	98e6dfc4c4	Migrate backend test suite from xUnit v2 to v3 ... - Directory.Packages.props: xunit 2.9.3 -> xunit.v3 4.0.0, bump xunit.runner.visualstudio to the matching 4.0.0 - All 5 test csproj: xunit -> xunit.v3 package reference, add <OutputType>Exe</OutputType> (v3 test projects are standalone executables) - backend/global.json: opt dotnet test into the new MTP-native mode (.NET 10 SDK removed the old VSTest bridge for MTP-based test projects like xunit v3) - IAsyncLifetime implementations (HandlerTestBase, ApiTestFixture, InfrastructureTestFixture, StorageServiceTests): v3's IAsyncLifetime now IS IAsyncDisposable, so InitializeAsync/DisposeAsync return ValueTask instead of Task. ApiTestFixture specifically now overrides WebApplicationFactory.DisposeAsync instead of implementing IAsyncLifetime.DisposeAsync explicitly, since v3 collapses both to the same single DisposeAsync slot - Replaced CancellationToken.None with TestContext.Current.CancellationToken across the suite (a v3-only API) and added it to every call that was silently omitting a CancellationToken argument, per the new xUnit1051 analyzer warnings that came with the v3 package Verified: dotnet build (0 warnings, 0 errors) and dotnet test, 250/250 passing under the new MTP runner.	2026-09-09 22:11:29 +02:00
Admin	a26f4b43fd	Add Infrastructure/Api/StreamingGateway test projects ... Second pass on backend/Tests/, covering what Domain+Application (the first pass) deliberately left out — the parts that talk to real infrastructure: Musify.Infrastructure.Tests Database/migrations, StorageService, StreamTicketService, AuditableEntityInterceptor, PictureService, SingleFlightCache, PlayListPresetSeeder. Musify.Api.Tests Real HTTP endpoints via WebApplicationFactory (routing, auth, ValidationFilter, ErrorOr->HTTP mapping), plus isolated unit tests for ErrorOrHttpExtensions, CurrentUser and the FluentValidation validators. Musify.StreamingGateway.Tests TicketValidator (RS256) and TicketValidationMiddleware (path traversal, prefix boundary, ticket extraction). Musify.Worker gets no test project: its Program.cs is pure DI/host wiring (Hangfire, MassTransit, jobs); the logic it runs lives in Musify.Infrastructure, already covered there. Per the user's direction, the parts that touch real infrastructure use Testcontainers instead of fakes: a real Postgres (Testcontainers.PostgreSql) for Infrastructure.Tests and Api.Tests, and — matching deploy/compose.yml exactly (chrislusf/seaweedfs:latest, same startup command), not MinIO — a real SeaweedFS container for StorageService. Api.Tests boots the actual Musify.Api host against that Postgres (real routing/auth/validation) but substitutes the services that talk over the network (storage, YouTube, the message bus, stream-ticket signing) with NSubstitute fakes, and swaps the JwtBearer scheme for a test-only header-based one (FakeAuthenticationHandler) so tests don't need a reachable Zitadel. Application.Tests' approach — a real DbContext (SQLite in-memory) rather than mocking IDatabase, since it exposes DbSet<T> directly and handlers compose real LINQ queries against it — carries over into Infrastructure.Tests/Api.Tests via real Postgres instead. Testing against the real backend (not a fake) found two genuine production bugs, both fixed here: - StorageService.RemoveFolderAsync threw NullReferenceException against SeaweedFS: its DeleteObjects response omits the <Error> list entirely when nothing failed, which the AWS SDK deserializes as null rather than an empty list (real AWS S3 always returns one). Now treats null as no errors. - AuditableEntityInterceptor never bumped UpdatedAt on a normal update (load, mutate a property, SaveChanges) — only on insert. SavingChanges(Async) fires before EF's own automatic change detection for that save, so an entity modified through a plain property setter still reported EntityState.Unchanged inside the interceptor. Now calls ChangeTracker.DetectChanges() explicitly first, which is the documented fix for exactly this interceptor pattern. Also required to make the Api host testable: Program.cs now ends with `public partial class Program;` (WebApplicationFactory<Program> needs the top-level- statements Program class to be public — no behavior change), and Directory.Packages.props gains Microsoft.AspNetCore.Mvc.Testing, Testcontainers and Testcontainers.PostgreSql. 249 tests total across all five projects, all green: `dotnet test backend/Musify.slnx` (needs Docker running for Infrastructure.Tests and Api.Tests).	2026-09-09 21:39:06 +02:00