Admin
611d9cd436
Two xUnit projects, wired into Musify.slnx under a /Tests/ folder that
mirrors Core/ and Hosts/:
Musify.Domain.Tests Value-object logic (TrackAudio/TrackPictures'
IsProcessed/IsFailed/IsInProgress). Entities are
otherwise anemic EF models with no behavior to
test.
Musify.Application.Tests All ~45 Application handlers and services
(Albums, Tracks, PlayLists, Users, Mixes,
YouTube, plus TrackStreamIssuer,
UploadIntentValidator, YouTubeTrackProvisioner).
IDatabase exposes DbSet<T> directly, so handlers compose real LINQ queries
against it — that can't be expressed with a mock (no IQueryable provider
behind one). TestSupport/TestDatabase.cs is instead a real DbContext on a
private SQLite in-memory connection per test (fresh per test since xUnit
instantiates the test class per test method): fast, no external dependency,
and — unlike EF Core's InMemory provider — SQLite enforces real foreign keys
and supports transactions, which two handlers need. External dependencies
(IStorageService, IEventBus, IYouTubeMusicService, ...) are substituted with
NSubstitute.
TestSupport/TestEntities.cs and TestConfigurations.cs build fully-populated
domain entities and configuration POCOs with sensible defaults for every
required member, so no test method needs to fill in properties it doesn't
care about, and no builder ever hands back null.
Also, needed to make the Application layer itself testable without a real
Postgres or user-secrets:
- DatabaseDesignTimeFactory now falls back to the Database__ConnectionString
env var, and DesignSettings.json is optional — unblocks the `migrate`
one-shot container from deploy/compose.yml, which hit the same gap.
- Directory.Packages.props: xunit, xunit.runner.visualstudio, NSubstitute,
Microsoft.EntityFrameworkCore.Sqlite (pinned to the same 10.0.8 as the rest
of EF Core), Microsoft.NET.Test.Sdk, coverlet.collector. Also pins
SQLitePCLRaw.bundle_e_sqlite3 to 2.1.13 — EFCore.Sqlite 10.0.8 pulls 2.1.11
transitively, which has a known high-severity advisory (GHSA-2m69-gcr7-jv3q).
- backend/.dockerignore excludes Tests/: no application Dockerfile needs it
in its build context.
162 tests, all green: `dotnet test backend/Musify.slnx`.
93 lines
3.6 KiB
C#
93 lines
3.6 KiB
C#
using ErrorOr;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Musify.Application.PlayLists;
|
|
using Musify.Application.Tests.TestSupport;
|
|
using Musify.Domain.Entities;
|
|
using Xunit;
|
|
|
|
namespace Musify.Application.Tests.PlayLists;
|
|
|
|
public sealed class AddTrackToPlayListCommandHandlerTests : HandlerTestBase
|
|
{
|
|
private AddTrackToPlayListCommandHandler CreateHandler() => new(Database, NoOpLogger<AddTrackToPlayListCommandHandler>());
|
|
|
|
[Fact]
|
|
public async Task Handle_FirstTrack_AddsItAtPositionZero()
|
|
{
|
|
var owner = TestEntities.User();
|
|
var playList = TestEntities.PlayList(owner.Id);
|
|
var track = TestEntities.LocalTrack(owner);
|
|
await SeedAsync(owner, playList, track);
|
|
|
|
var result = await CreateHandler().Handle(new AddTrackToPlayListCommand(owner.Id, playList.Id, track.Id), CancellationToken.None);
|
|
|
|
Assert.False(result.IsError);
|
|
var link = Assert.Single(await Database.PlayListHasTracks.ToListAsync());
|
|
Assert.Equal(0, link.Position);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_PlayListAlreadyHasTracks_AppendsAtNextPosition()
|
|
{
|
|
var owner = TestEntities.User();
|
|
var playList = TestEntities.PlayList(owner.Id);
|
|
var existingTrack = TestEntities.LocalTrack(owner, "Existing");
|
|
var newTrack = TestEntities.LocalTrack(owner, "New");
|
|
await SeedAsync(
|
|
owner, playList, existingTrack, newTrack,
|
|
new PlayListHasTrack { PlayListId = playList.Id, TrackId = existingTrack.Id, Position = 0 });
|
|
|
|
var result = await CreateHandler().Handle(new AddTrackToPlayListCommand(owner.Id, playList.Id, newTrack.Id), CancellationToken.None);
|
|
|
|
Assert.False(result.IsError);
|
|
var newLink = await Database.PlayListHasTracks.SingleAsync(link => link.TrackId == newTrack.Id);
|
|
Assert.Equal(1, newLink.Position);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_PlayListMissing_ReturnsNotFound()
|
|
{
|
|
var result = await CreateHandler().Handle(new AddTrackToPlayListCommand(1, Guid.NewGuid(), Guid.NewGuid()), CancellationToken.None);
|
|
|
|
Assert.Equal(ErrorType.NotFound, result.FirstError.Type);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_NotOwner_ReturnsUnauthorized()
|
|
{
|
|
var owner = TestEntities.User(1, "owner");
|
|
var stranger = TestEntities.User(2, "stranger");
|
|
var playList = TestEntities.PlayList(owner.Id);
|
|
await SeedAsync(owner, stranger, playList);
|
|
|
|
var result = await CreateHandler().Handle(new AddTrackToPlayListCommand(stranger.Id, playList.Id, Guid.NewGuid()), CancellationToken.None);
|
|
|
|
Assert.Equal(ErrorType.Unauthorized, result.FirstError.Type);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_TrackMissing_ReturnsNotFound()
|
|
{
|
|
var owner = TestEntities.User();
|
|
var playList = TestEntities.PlayList(owner.Id);
|
|
await SeedAsync(owner, playList);
|
|
|
|
var result = await CreateHandler().Handle(new AddTrackToPlayListCommand(owner.Id, playList.Id, Guid.NewGuid()), CancellationToken.None);
|
|
|
|
Assert.Equal(ErrorType.NotFound, result.FirstError.Type);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_TrackAlreadyInPlayList_ReturnsConflict()
|
|
{
|
|
var owner = TestEntities.User();
|
|
var playList = TestEntities.PlayList(owner.Id);
|
|
var track = TestEntities.LocalTrack(owner);
|
|
await SeedAsync(owner, playList, track, new PlayListHasTrack { PlayListId = playList.Id, TrackId = track.Id, Position = 0 });
|
|
|
|
var result = await CreateHandler().Handle(new AddTrackToPlayListCommand(owner.Id, playList.Id, track.Id), CancellationToken.None);
|
|
|
|
Assert.Equal(ErrorType.Conflict, result.FirstError.Type);
|
|
}
|
|
}
|