Ardalis Result<T> carried incoherent success sub-statuses and a clunky generic converter; ErrorOr models success-or-errors cleanly. - Application: all commands/queries/handlers now return ErrorOr<T> (non-generic Result -> ErrorOr<Success>); errors via Error.NotFound/ Conflict/Validation/Unauthorized/Failure; success via value or new Success() - Drop ResultExtensions.As<>(): error propagation is now just return .Errors - Rewrite HTTP mapping (ErrorOrHttpExtensions) off Error.Type; success maps to 200 (value) or 204 (Success); Created still built in the endpoints - Endpoints/gateway middleware: !IsSuccess -> IsError - Swap Ardalis.Result package for ErrorOr 2.1.1 (remove unused ref from Worker) Build: 0 warnings, 0 errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
68 lines
2.0 KiB
C#
68 lines
2.0 KiB
C#
using Mediator;
|
|
using Musify.Application.Users.Commands;
|
|
using Musify.Application.Users.Queries;
|
|
using Musify.Api.DataTransferObjects.Users;
|
|
using Musify.Api.Extensions;
|
|
using Musify.Api.Filters;
|
|
|
|
namespace Musify.Api.Endpoints;
|
|
|
|
public static class UserEndpoints
|
|
{
|
|
public static IEndpointRouteBuilder MapUserEndpoints(this IEndpointRouteBuilder app)
|
|
{
|
|
var group = app.MapGroup("/users")
|
|
.WithTags("Users");
|
|
|
|
group.MapGet("/", GetUsers)
|
|
.WithName("GetUsers")
|
|
.WithSummary("Get Paginated Users.");
|
|
|
|
group.MapGet("/{id}", GetUserById)
|
|
.WithName("GetUserById")
|
|
.WithSummary("Get A User By Id.");
|
|
|
|
group.MapPost("/", CreateUser)
|
|
.WithName("CreateUser")
|
|
.WithSummary("Create A New User.")
|
|
.AddEndpointFilter<ValidationFilter<CreateUserRequest>>();
|
|
|
|
return app;
|
|
}
|
|
|
|
private static async Task<IResult> GetUsers(
|
|
IMediator mediator,
|
|
CancellationToken cancellationToken,
|
|
string? usernameSearch,
|
|
int pageNumber = 1,
|
|
int pageSize = 10)
|
|
{
|
|
var result = await mediator.Send(new GetUsersQuery(pageNumber, pageSize, usernameSearch), cancellationToken);
|
|
return result.ToHttpResult();
|
|
}
|
|
|
|
private static async Task<IResult> GetUserById(
|
|
IMediator mediator,
|
|
long id,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
var result = await mediator.Send(new GetUserByIdQuery(id), cancellationToken);
|
|
return result.ToHttpResult();
|
|
}
|
|
|
|
private static async Task<IResult> CreateUser(
|
|
IMediator mediator,
|
|
CreateUserRequest request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
var result = await mediator.Send(
|
|
new CreateUserCommand(request.Id, request.Name, request.FirstName, request.SecondName),
|
|
cancellationToken);
|
|
|
|
if (result.IsError)
|
|
return result.ToHttpResult();
|
|
|
|
return Results.Created($"/users/{result.Value.Id}", result.Value);
|
|
}
|
|
}
|