Ardalis Result<T> carried incoherent success sub-statuses and a clunky generic converter; ErrorOr models success-or-errors cleanly. - Application: all commands/queries/handlers now return ErrorOr<T> (non-generic Result -> ErrorOr<Success>); errors via Error.NotFound/ Conflict/Validation/Unauthorized/Failure; success via value or new Success() - Drop ResultExtensions.As<>(): error propagation is now just return .Errors - Rewrite HTTP mapping (ErrorOrHttpExtensions) off Error.Type; success maps to 200 (value) or 204 (Success); Created still built in the endpoints - Endpoints/gateway middleware: !IsSuccess -> IsError - Swap Ardalis.Result package for ErrorOr 2.1.1 (remove unused ref from Worker) Build: 0 warnings, 0 errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
130 lines
5.6 KiB
C#
130 lines
5.6 KiB
C#
using ErrorOr;
|
|
using Mediator;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.Logging;
|
|
using Musify.Application.Configuration;
|
|
using Musify.Application.Shared;
|
|
using Musify.Application.Events;
|
|
using Musify.Application.PlayLists.Commands;
|
|
using Musify.Application.PlayLists.Responses;
|
|
using Musify.Application.Services;
|
|
using Musify.Domain.Entities;
|
|
using Musify.Application.Contracts;
|
|
|
|
namespace Musify.Application.PlayLists.Handlers
|
|
{
|
|
public class UpdatePlayListCommandHandler(
|
|
IEventBus eventBus,
|
|
IDatabase database,
|
|
UploadIntentValidator uploadIntentValidator,
|
|
ILogger<UpdatePlayListCommandHandler> logger,
|
|
ApplicationStorageConfiguration storageConfiguration,
|
|
PlayListConfiguration playListConfiguration,
|
|
UploadIntentConfiguration uploadIntentConfiguration)
|
|
: ICommandHandler<UpdatePlayListCommand, ErrorOr<PlayListApplicationResponse>>
|
|
{
|
|
public async ValueTask<ErrorOr<PlayListApplicationResponse>> Handle(UpdatePlayListCommand request, CancellationToken cancellationToken)
|
|
{
|
|
var playListEntity = await database.PlayLists.SingleOrDefaultAsync(pl => pl.Id == request.PlayListId, cancellationToken);
|
|
if (playListEntity is null)
|
|
{
|
|
logger.LogInformation("Playlist {PlayListId} not found", request.PlayListId);
|
|
return Error.NotFound();
|
|
}
|
|
|
|
if (playListEntity.UserId != request.UserId)
|
|
{
|
|
logger.LogWarning("User {UserId} is not the owner of playlist {PlayListId}", request.UserId, request.PlayListId);
|
|
return Error.Unauthorized();
|
|
}
|
|
|
|
if (request.NewName is not null)
|
|
{
|
|
playListEntity.Name = request.NewName;
|
|
playListEntity.NormalizedName = request.NewName.Trim().ToUpperInvariant();
|
|
}
|
|
|
|
if (request.NewDescription is not null)
|
|
{
|
|
playListEntity.Description = request.NewDescription;
|
|
}
|
|
|
|
UploadIntent? pictureIntent = null;
|
|
string? finalPictureKey = null;
|
|
|
|
if (request.NewPictureIntentId.HasValue)
|
|
{
|
|
var validation = await uploadIntentValidator.ValidateAndLoadAsync(
|
|
uploadIntentConfiguration,
|
|
request.NewPictureIntentId.Value, request.UserId, cancellationToken);
|
|
if (validation.IsError)
|
|
return validation.Errors;
|
|
|
|
pictureIntent = validation.Value;
|
|
playListEntity.OriginalPictureName = pictureIntent.ObjectName;
|
|
finalPictureKey = playListConfiguration.Routes.BuildOriginalPicturePath(request.UserId, pictureIntent.ObjectName);
|
|
}
|
|
|
|
database.PlayLists.Update(playListEntity);
|
|
|
|
if (pictureIntent is not null && finalPictureKey is not null)
|
|
{
|
|
var publishResult = await PublishUpdatePlayListPictureSourceEventAsync(
|
|
playListEntity.Id, pictureIntent, finalPictureKey, cancellationToken);
|
|
if (publishResult.IsError)
|
|
return publishResult.Errors;
|
|
}
|
|
|
|
try
|
|
{
|
|
await database.SaveChangesAsync(cancellationToken);
|
|
}
|
|
catch (Exception exception)
|
|
{
|
|
logger.LogError(exception, "Failed to update playlist {PlayListId}", playListEntity.Id);
|
|
return Error.Failure(description: $"Failed to update playlist {playListEntity.Id}");
|
|
}
|
|
|
|
logger.LogInformation("Updated playlist {PlayListId}", playListEntity.Id);
|
|
return PlayListApplicationResponse.FromEntity(playListEntity);
|
|
}
|
|
|
|
async Task<ErrorOr<Success>> PublishUpdatePlayListPictureSourceEventAsync(
|
|
Guid playListId,
|
|
UploadIntent pictureIntent,
|
|
string finalPictureKey,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
try
|
|
{
|
|
await eventBus.PublishAsync(
|
|
new UpdatePlayListPictureSourceEvent(
|
|
playListId,
|
|
pictureIntent.Id,
|
|
storageConfiguration.Bucket,
|
|
pictureIntent.Key,
|
|
finalPictureKey,
|
|
new ImageSize(
|
|
playListConfiguration.Routes.SmallPicturesPath,
|
|
playListConfiguration.PicturesSizes.SmallPictureWidth,
|
|
playListConfiguration.PicturesSizes.SmallPictureHeight),
|
|
new ImageSize(
|
|
playListConfiguration.Routes.MediumPicturesPath,
|
|
playListConfiguration.PicturesSizes.MediumPictureWidth,
|
|
playListConfiguration.PicturesSizes.MediumPictureHeight),
|
|
new ImageSize(
|
|
playListConfiguration.Routes.LargePicturesPath,
|
|
playListConfiguration.PicturesSizes.LargePictureWidth,
|
|
playListConfiguration.PicturesSizes.LargePictureHeight)),
|
|
cancellationToken);
|
|
return new Success();
|
|
}
|
|
catch (Exception exception)
|
|
{
|
|
logger.LogError(exception, "Failed to publish update playlist picture source event for playlist {PlayListId}", playListId);
|
|
return Error.Failure(description: $"Failed to publish update playlist picture source event for playlist {playListId}");
|
|
}
|
|
}
|
|
}
|
|
}
|