Ardalis Result<T> carried incoherent success sub-statuses and a clunky generic converter; ErrorOr models success-or-errors cleanly. - Application: all commands/queries/handlers now return ErrorOr<T> (non-generic Result -> ErrorOr<Success>); errors via Error.NotFound/ Conflict/Validation/Unauthorized/Failure; success via value or new Success() - Drop ResultExtensions.As<>(): error propagation is now just return .Errors - Rewrite HTTP mapping (ErrorOrHttpExtensions) off Error.Type; success maps to 200 (value) or 204 (Success); Created still built in the endpoints - Endpoints/gateway middleware: !IsSuccess -> IsError - Swap Ardalis.Result package for ErrorOr 2.1.1 (remove unused ref from Worker) Build: 0 warnings, 0 errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
70 lines
2.7 KiB
C#
70 lines
2.7 KiB
C#
using ErrorOr;
|
|
using Mediator;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.Logging;
|
|
using Musify.Application.Tracks.Commands;
|
|
using Musify.Domain.ValueObjects;
|
|
using Musify.Application.Events;
|
|
using Musify.Application.Contracts;
|
|
|
|
namespace Musify.Application.Tracks.Handlers
|
|
{
|
|
public class DeleteTrackCommandHandler(
|
|
IDatabase database,
|
|
IEventBus eventBus,
|
|
ILogger<DeleteTrackCommandHandler> logger)
|
|
: ICommandHandler<DeleteTrackCommand, ErrorOr<Success>>
|
|
{
|
|
public async ValueTask<ErrorOr<Success>> Handle(DeleteTrackCommand request, CancellationToken cancellationToken)
|
|
{
|
|
var track = await database.Tracks.SingleOrDefaultAsync(t => t.Id == request.TrackId, cancellationToken);
|
|
if (track is null)
|
|
{
|
|
logger.LogInformation("Track {TrackId} not found", request.TrackId);
|
|
return Error.NotFound();
|
|
}
|
|
|
|
var isOwner = await database.UserHasTracks
|
|
.AsNoTracking()
|
|
.AnyAsync(ut => ut.TrackId == request.TrackId && ut.UserId == request.UserId, cancellationToken);
|
|
if (!isOwner)
|
|
{
|
|
logger.LogWarning("User {UserId} unauthorized to delete track {TrackId}", request.UserId, request.TrackId);
|
|
return Error.Unauthorized();
|
|
}
|
|
|
|
if (track.AudioTranscodeProcessingStatus == ProcessingStatus.Processing
|
|
|| track.AudioTranscodeProcessingStatus == ProcessingStatus.Pending)
|
|
{
|
|
logger.LogWarning("Track {TrackId} is currently being processed and cannot be deleted", request.TrackId);
|
|
return Error.Conflict(description: "Track is currently being processed and cannot be deleted");
|
|
}
|
|
|
|
track.LifeCycleStatus = LifeCycleStatus.Removing;
|
|
|
|
try
|
|
{
|
|
await eventBus.PublishAsync(
|
|
new DeleteTrackEvent(track.Id, request.UserId),
|
|
cancellationToken);
|
|
}
|
|
catch (Exception exception)
|
|
{
|
|
logger.LogError(exception, "Failed to publish delete track event for track {TrackId}", request.TrackId);
|
|
return Error.Failure(description: $"Failed to delete track {request.TrackId}");
|
|
}
|
|
|
|
try
|
|
{
|
|
await database.SaveChangesAsync(cancellationToken);
|
|
}
|
|
catch (Exception exception)
|
|
{
|
|
logger.LogError(exception, "Failed to mark track {TrackId} as processing before deletion", request.TrackId);
|
|
return Error.Failure(description: $"Failed to delete track {request.TrackId}");
|
|
}
|
|
|
|
return new Success();
|
|
}
|
|
}
|
|
} |