New Playback:AllowAnonymousListening / Playback:AnonymousFragmentSeconds
settings control whether a request without a session can stream at all,
and if so, whether it's limited to a fragment instead of the full track:
- GET /tracks/{id}/stream and GET /youtube/tracks/{videoId}/stream no
longer require authorization outright; the handlers gate on the config
instead, so both keep working exactly as before when it's off (the
default).
- The fragment cap is enforced by the Streaming Gateway, not the client:
the stream ticket now carries an optional maxBytes claim (computed from
AnonymousFragmentSeconds and the transcoder's known bitrate), and
TicketValidationMiddleware clamps the Range it forwards to SeaweedFS to
stay under it — synthesizing one if the request didn't send one, and
answering 416 outright if the requested range starts past the cap.
- A YouTube track that hasn't been provisioned server-side yet streams
straight from YouTube's CDN, bypassing the Gateway entirely — there's no
way to cap that, so an anonymous request for one is refused (409) instead
of silently handing out an uncapped stream.
- ListeningHistory has a non-nullable UserId, so anonymous plays simply
don't get recorded rather than trying to force a row through the FK.
Also fixes a real, pre-existing bug this surfaced: the AppSettings.Development.json
of the Api, Worker, and StreamingGateway all pointed StreamTicket/Workers
paths at "../../deploy/..." — one directory short of deploy/'s actual
location at the repo root relative to each project's own folder. Docker
never hit this (it mounts an absolute /keys path), so it had apparently
never been exercised via `dotnet run` before.
92 lines
4.1 KiB
C#
92 lines
4.1 KiB
C#
using ErrorOr;
|
|
using Mediator;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.Logging;
|
|
using Musify.Application.Configuration;
|
|
using Musify.Application.Contracts;
|
|
using Musify.Application.Services;
|
|
using Musify.Application.YouTube.Responses;
|
|
using Musify.Domain.Entities;
|
|
|
|
namespace Musify.Application.YouTube
|
|
{
|
|
/// <param name="UserId">Null for an anonymous request — allowed only when
|
|
/// <see cref="PlaybackConfiguration.AllowAnonymousListening"/> is enabled.</param>
|
|
public record ResolveYouTubeTrackStreamCommand(string VideoId, long? UserId)
|
|
: ICommand<ErrorOr<YouTubeStreamResponse>>;
|
|
|
|
public class ResolveYouTubeTrackStreamCommandHandler(
|
|
IDatabase database,
|
|
IYouTubeMusicService youTubeMusicService,
|
|
YouTubeTrackProvisioner provisioner,
|
|
TrackStreamIssuer streamIssuer,
|
|
PlaybackConfiguration playbackConfiguration,
|
|
ILogger<ResolveYouTubeTrackStreamCommandHandler> logger)
|
|
: ICommandHandler<ResolveYouTubeTrackStreamCommand, ErrorOr<YouTubeStreamResponse>>
|
|
{
|
|
public async ValueTask<ErrorOr<YouTubeStreamResponse>> Handle(ResolveYouTubeTrackStreamCommand request, CancellationToken cancellationToken)
|
|
{
|
|
var isAnonymous = request.UserId is null;
|
|
if (isAnonymous && !playbackConfiguration.AllowAnonymousListening)
|
|
return Error.Unauthorized(description: "Sign in to stream music, or ask an administrator to enable anonymous listening.");
|
|
|
|
var track = await provisioner.FindAsync(request.VideoId, cancellationToken);
|
|
|
|
if (track != null && track.Audio.IsProcessed)
|
|
{
|
|
var serverStream = await streamIssuer.IssueAsync(track.Id, track.Audio.FolderName, request.UserId, cancellationToken);
|
|
return new YouTubeStreamResponse(
|
|
track.Id,
|
|
YouTubeStreamMode.Server,
|
|
serverStream.ManifestUrl,
|
|
serverStream.Ticket,
|
|
serverStream.ExpiresInSeconds);
|
|
}
|
|
|
|
// Below this point the only option left is streaming straight from YouTube's own CDN,
|
|
// which bypasses our Gateway (and its stream tickets) entirely — there's no way to cap that
|
|
// to the configured anonymous fragment, so an anonymous listener simply doesn't get it: they
|
|
// can retry once the track has been provisioned server-side, where the cap above applies.
|
|
if (isAnonymous && playbackConfiguration.AnonymousFragmentSeconds > 0)
|
|
return Error.Conflict(description: "This track isn't available for anonymous preview yet. Try again in a moment.");
|
|
|
|
var streamInfo = await youTubeMusicService.GetAudioStreamAsync(request.VideoId, cancellationToken);
|
|
if (streamInfo.IsError)
|
|
return streamInfo.Errors;
|
|
|
|
if (track == null)
|
|
{
|
|
var provisionResult = await provisioner.GetOrCreateAsync(request.VideoId, cancellationToken);
|
|
if (!provisionResult.IsError)
|
|
track = provisionResult.Value.Track;
|
|
else
|
|
logger.LogWarning("Could not provision YouTube track {VideoId}: {Error}", request.VideoId, provisionResult.FirstError.Description);
|
|
}
|
|
|
|
if (track != null && request.UserId is not null)
|
|
{
|
|
await database.ListeningHistories.AddAsync(new ListeningHistory
|
|
{
|
|
UserId = request.UserId.Value,
|
|
TrackId = track.Id,
|
|
}, cancellationToken);
|
|
|
|
try
|
|
{
|
|
await database.SaveChangesAsync(cancellationToken);
|
|
}
|
|
catch (DbUpdateException exception)
|
|
{
|
|
logger.LogWarning(exception, "Failed to record listening history for YouTube video {VideoId}", request.VideoId);
|
|
}
|
|
}
|
|
|
|
return new YouTubeStreamResponse(
|
|
track?.Id,
|
|
YouTubeStreamMode.YouTube,
|
|
streamInfo.Value.Url, null,
|
|
streamInfo.Value.ExpiresInSeconds);
|
|
}
|
|
}
|
|
}
|