- Directory.Packages.props: xunit 2.9.3 -> xunit.v3 4.0.0, bump xunit.runner.visualstudio to the matching 4.0.0 - All 5 test csproj: xunit -> xunit.v3 package reference, add <OutputType>Exe</OutputType> (v3 test projects are standalone executables) - backend/global.json: opt dotnet test into the new MTP-native mode (.NET 10 SDK removed the old VSTest bridge for MTP-based test projects like xunit v3) - IAsyncLifetime implementations (HandlerTestBase, ApiTestFixture, InfrastructureTestFixture, StorageServiceTests): v3's IAsyncLifetime now IS IAsyncDisposable, so InitializeAsync/DisposeAsync return ValueTask instead of Task. ApiTestFixture specifically now overrides WebApplicationFactory.DisposeAsync instead of implementing IAsyncLifetime.DisposeAsync explicitly, since v3 collapses both to the same single DisposeAsync slot - Replaced CancellationToken.None with TestContext.Current.CancellationToken across the suite (a v3-only API) and added it to every call that was silently omitting a CancellationToken argument, per the new xUnit1051 analyzer warnings that came with the v3 package Verified: dotnet build (0 warnings, 0 errors) and dotnet test, 250/250 passing under the new MTP runner.
81 lines
3.3 KiB
C#
81 lines
3.3 KiB
C#
using ErrorOr;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Musify.Application.Configuration;
|
|
using Musify.Application.Contracts;
|
|
using Musify.Application.Services;
|
|
using Musify.Application.Tests.TestSupport;
|
|
using Musify.Application.Tracks;
|
|
using Musify.Domain.ValueObjects;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Musify.Application.Tests.Tracks;
|
|
|
|
public sealed class RequestTrackUploadUrlsCommandHandlerTests : HandlerTestBase
|
|
{
|
|
private readonly IStorageService storageService = Substitute.For<IStorageService>();
|
|
|
|
private RequestTrackUploadUrlsCommandHandler CreateHandler(UploadIntentConfiguration? uploadIntentConfig = null)
|
|
{
|
|
storageService
|
|
.GetUploadUrlAsync(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>(), Arg.Any<TimeSpan>(), Arg.Any<CancellationToken>())
|
|
.Returns("https://storage.musify.test/presigned-upload");
|
|
|
|
return new RequestTrackUploadUrlsCommandHandler(
|
|
Database,
|
|
new UploadIntentValidator(Database, storageService),
|
|
storageService,
|
|
NoOpLogger<RequestTrackUploadUrlsCommandHandler>(),
|
|
TestConfigurations.Storage(),
|
|
TestConfigurations.Track(),
|
|
uploadIntentConfig ?? TestConfigurations.UploadIntent());
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_UserExists_IssuesBothUploadUrlsAndCreatesIntents()
|
|
{
|
|
var user = TestEntities.User();
|
|
await SeedAsync(user);
|
|
|
|
var command = new RequestTrackUploadUrlsCommand(user.Id, "webp", "image/webp", "mp3", "audio/mpeg");
|
|
|
|
var result = await CreateHandler().Handle(command, TestContext.Current.CancellationToken);
|
|
|
|
Assert.False(result.IsError);
|
|
Assert.Equal("https://storage.musify.test/presigned-upload", result.Value.PictureUploadUrl);
|
|
Assert.Equal("https://storage.musify.test/presigned-upload", result.Value.AudioUploadUrl);
|
|
|
|
var intents = await Database.UploadIntents.Where(intent => intent.UserId == user.Id).ToListAsync(TestContext.Current.CancellationToken);
|
|
Assert.Equal(2, intents.Count);
|
|
Assert.Contains(intents, intent => intent.Purpose == UploadIntentPurpose.TrackPicture);
|
|
Assert.Contains(intents, intent => intent.Purpose == UploadIntentPurpose.TrackAudio);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_UserMissing_ReturnsNotFound()
|
|
{
|
|
var command = new RequestTrackUploadUrlsCommand(404, "webp", "image/webp", "mp3", "audio/mpeg");
|
|
|
|
var result = await CreateHandler().Handle(command, TestContext.Current.CancellationToken);
|
|
|
|
Assert.Equal(ErrorType.NotFound, result.FirstError.Type);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_UserAtActiveIntentLimit_ReturnsValidationErrorAndCreatesNothing()
|
|
{
|
|
var config = TestConfigurations.UploadIntent();
|
|
config.MaxActiveUploadIntentsPerUser = 1;
|
|
|
|
var user = TestEntities.User();
|
|
await SeedAsync(user, TestEntities.UploadIntent(user.Id));
|
|
|
|
var command = new RequestTrackUploadUrlsCommand(user.Id, "webp", "image/webp", "mp3", "audio/mpeg");
|
|
|
|
var result = await CreateHandler(config).Handle(command, TestContext.Current.CancellationToken);
|
|
|
|
Assert.Equal(ErrorType.Validation, result.FirstError.Type);
|
|
Assert.Equal(1, await Database.UploadIntents.CountAsync(TestContext.Current.CancellationToken));
|
|
}
|
|
}
|