- Directory.Packages.props: xunit 2.9.3 -> xunit.v3 4.0.0, bump xunit.runner.visualstudio to the matching 4.0.0 - All 5 test csproj: xunit -> xunit.v3 package reference, add <OutputType>Exe</OutputType> (v3 test projects are standalone executables) - backend/global.json: opt dotnet test into the new MTP-native mode (.NET 10 SDK removed the old VSTest bridge for MTP-based test projects like xunit v3) - IAsyncLifetime implementations (HandlerTestBase, ApiTestFixture, InfrastructureTestFixture, StorageServiceTests): v3's IAsyncLifetime now IS IAsyncDisposable, so InitializeAsync/DisposeAsync return ValueTask instead of Task. ApiTestFixture specifically now overrides WebApplicationFactory.DisposeAsync instead of implementing IAsyncLifetime.DisposeAsync explicitly, since v3 collapses both to the same single DisposeAsync slot - Replaced CancellationToken.None with TestContext.Current.CancellationToken across the suite (a v3-only API) and added it to every call that was silently omitting a CancellationToken argument, per the new xUnit1051 analyzer warnings that came with the v3 package Verified: dotnet build (0 warnings, 0 errors) and dotnet test, 250/250 passing under the new MTP runner.
62 lines
2.3 KiB
C#
62 lines
2.3 KiB
C#
using ErrorOr;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Musify.Application.Contracts;
|
|
using Musify.Application.Services;
|
|
using Musify.Application.Tests.TestSupport;
|
|
using Musify.Application.YouTube;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Musify.Application.Tests.YouTube;
|
|
|
|
public sealed class GetYouTubeAlbumQueryHandlerTests : HandlerTestBase
|
|
{
|
|
private readonly IYouTubeMusicService youTubeMusicService = Substitute.For<IYouTubeMusicService>();
|
|
|
|
private GetYouTubeAlbumQueryHandler CreateHandler()
|
|
{
|
|
var provisioner = new YouTubeTrackProvisioner(
|
|
Database, youTubeMusicService, TestConfigurations.Track(), NoOpLogger<YouTubeTrackProvisioner>());
|
|
|
|
return new GetYouTubeAlbumQueryHandler(youTubeMusicService, provisioner, NoOpLogger<GetYouTubeAlbumQueryHandler>());
|
|
}
|
|
|
|
private static YouTubeAlbumDetail BuildDetail() => new(
|
|
new YouTubeAlbumResult("album-1", "Album Title", "Album Artist", "https://img/thumb.jpg", 2024, false, false, []),
|
|
Description: "An album",
|
|
TotalDurationSeconds: 600,
|
|
Tracks: [new YouTubeAlbumTrack("track-1", "Track One", 200, 1, false)]);
|
|
|
|
[Fact]
|
|
public async Task Handle_EmptyAlbumId_ReturnsValidationError()
|
|
{
|
|
var result = await CreateHandler().Handle(new GetYouTubeAlbumQuery(string.Empty), TestContext.Current.CancellationToken);
|
|
|
|
Assert.Equal(ErrorType.Validation, result.FirstError.Type);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_ServiceSucceeds_MaterializesAlbumAndReturnsDetail()
|
|
{
|
|
var detail = BuildDetail();
|
|
youTubeMusicService.GetAlbumAsync("album-1", Arg.Any<CancellationToken>()).Returns(detail);
|
|
|
|
var result = await CreateHandler().Handle(new GetYouTubeAlbumQuery("album-1"), TestContext.Current.CancellationToken);
|
|
|
|
Assert.False(result.IsError);
|
|
Assert.Same(detail, result.Value);
|
|
Assert.NotEmpty(await Database.ExternalAlbums.ToListAsync(TestContext.Current.CancellationToken));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_ServiceFails_ReturnsError()
|
|
{
|
|
youTubeMusicService.GetAlbumAsync("missing", Arg.Any<CancellationToken>())
|
|
.Returns(Error.NotFound(description: "Album not found"));
|
|
|
|
var result = await CreateHandler().Handle(new GetYouTubeAlbumQuery("missing"), TestContext.Current.CancellationToken);
|
|
|
|
Assert.True(result.IsError);
|
|
}
|
|
}
|