New Playback:AllowAnonymousListening / Playback:AnonymousFragmentSeconds
settings control whether a request without a session can stream at all,
and if so, whether it's limited to a fragment instead of the full track:
- GET /tracks/{id}/stream and GET /youtube/tracks/{videoId}/stream no
longer require authorization outright; the handlers gate on the config
instead, so both keep working exactly as before when it's off (the
default).
- The fragment cap is enforced by the Streaming Gateway, not the client:
the stream ticket now carries an optional maxBytes claim (computed from
AnonymousFragmentSeconds and the transcoder's known bitrate), and
TicketValidationMiddleware clamps the Range it forwards to SeaweedFS to
stay under it — synthesizing one if the request didn't send one, and
answering 416 outright if the requested range starts past the cap.
- A YouTube track that hasn't been provisioned server-side yet streams
straight from YouTube's CDN, bypassing the Gateway entirely — there's no
way to cap that, so an anonymous request for one is refused (409) instead
of silently handing out an uncapped stream.
- ListeningHistory has a non-nullable UserId, so anonymous plays simply
don't get recorded rather than trying to force a row through the FK.
Also fixes a real, pre-existing bug this surfaced: the AppSettings.Development.json
of the Api, Worker, and StreamingGateway all pointed StreamTicket/Workers
paths at "../../deploy/..." — one directory short of deploy/'s actual
location at the repo root relative to each project's own folder. Docker
never hit this (it mounts an absolute /keys path), so it had apparently
never been exercised via `dotnet run` before.
126 lines
6.7 KiB
C#
126 lines
6.7 KiB
C#
using ErrorOr;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Musify.Application.Configuration;
|
|
using Musify.Application.Contracts;
|
|
using Musify.Application.Services;
|
|
using Musify.Application.Tests.TestSupport;
|
|
using Musify.Application.YouTube;
|
|
using Musify.Application.YouTube.Responses;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Musify.Application.Tests.YouTube
|
|
{
|
|
public sealed class ResolveYouTubeTrackStreamCommandHandlerTests : HandlerTestBase
|
|
{
|
|
private readonly IYouTubeMusicService youTubeMusicService = Substitute.For<IYouTubeMusicService>();
|
|
private readonly IStreamTicketService ticketService = Substitute.For<IStreamTicketService>();
|
|
|
|
private ResolveYouTubeTrackStreamCommandHandler CreateHandler(PlaybackConfiguration? playback = null)
|
|
{
|
|
playback ??= TestConfigurations.Playback();
|
|
var provisioner = new YouTubeTrackProvisioner(
|
|
Database, youTubeMusicService, TestConfigurations.Track(), NoOpLogger<YouTubeTrackProvisioner>());
|
|
var issuer = new TrackStreamIssuer(
|
|
Database, ticketService, TestConfigurations.Track(), TestConfigurations.StreamGateway(), playback);
|
|
|
|
return new ResolveYouTubeTrackStreamCommandHandler(
|
|
Database, youTubeMusicService, provisioner, issuer, playback, NoOpLogger<ResolveYouTubeTrackStreamCommandHandler>());
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_AlreadyProcessedTrack_IssuesServerStreamWithoutCallingYouTubeForAudio()
|
|
{
|
|
ticketService.IssueTicket(Arg.Any<long?>(), Arg.Any<string>(), Arg.Any<long?>()).Returns(new StreamTicket("token", 60));
|
|
|
|
var user = TestEntities.User(1);
|
|
var track = TestEntities.ExternalTrack(externalId: "abc123");
|
|
await SeedAsync(user, track);
|
|
|
|
var result = await CreateHandler().Handle(new ResolveYouTubeTrackStreamCommand("abc123", 1), TestContext.Current.CancellationToken);
|
|
|
|
Assert.False(result.IsError);
|
|
Assert.Equal(YouTubeStreamMode.Server, result.Value.Mode);
|
|
Assert.Equal("token", result.Value.Ticket);
|
|
await youTubeMusicService.DidNotReceiveWithAnyArgs().GetAudioStreamAsync(default!, TestContext.Current.CancellationToken);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_UnknownTrack_ProvisionsItAndRecordsListeningHistory()
|
|
{
|
|
youTubeMusicService.GetAudioStreamAsync("new-video", Arg.Any<CancellationToken>())
|
|
.Returns(new YouTubeStreamInfo("https://youtube.example/stream", 300));
|
|
youTubeMusicService.GetSongAsync("new-video", Arg.Any<CancellationToken>())
|
|
.Returns(new YouTubeSongResult("new-video", "Title", "Artist", "Album", 200, "https://img/thumb.jpg", false, []));
|
|
youTubeMusicService.ResolveArtworkUrl(Arg.Any<string>()).Returns(callInfo => callInfo.Arg<string>());
|
|
await SeedAsync(TestEntities.User(42));
|
|
|
|
var result = await CreateHandler().Handle(new ResolveYouTubeTrackStreamCommand("new-video", 42), TestContext.Current.CancellationToken);
|
|
|
|
Assert.False(result.IsError);
|
|
Assert.Equal(YouTubeStreamMode.YouTube, result.Value.Mode);
|
|
Assert.Equal("https://youtube.example/stream", result.Value.StreamUrl);
|
|
Assert.NotNull(result.Value.TrackId);
|
|
|
|
var history = Assert.Single(await Database.ListeningHistories.ToListAsync(TestContext.Current.CancellationToken));
|
|
Assert.Equal(42, history.UserId);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_AnonymousUser_AnonymousListeningDisabled_ReturnsUnauthorized()
|
|
{
|
|
var handler = CreateHandler(TestConfigurations.Playback(allowAnonymousListening: false));
|
|
|
|
var result = await handler.Handle(new ResolveYouTubeTrackStreamCommand("abc123", UserId: null), TestContext.Current.CancellationToken);
|
|
|
|
Assert.Equal(ErrorType.Unauthorized, result.FirstError.Type);
|
|
await youTubeMusicService.DidNotReceiveWithAnyArgs().GetAudioStreamAsync(default!, TestContext.Current.CancellationToken);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_AnonymousUser_AlreadyProcessedTrack_IssuesServerStreamWithoutRecordingHistory()
|
|
{
|
|
ticketService.IssueTicket(Arg.Any<long?>(), Arg.Any<string>(), Arg.Any<long?>()).Returns(new StreamTicket("token", 60));
|
|
var track = TestEntities.ExternalTrack(externalId: "abc123");
|
|
await SeedAsync(track);
|
|
|
|
var handler = CreateHandler(TestConfigurations.Playback(allowAnonymousListening: true));
|
|
|
|
var result = await handler.Handle(new ResolveYouTubeTrackStreamCommand("abc123", UserId: null), TestContext.Current.CancellationToken);
|
|
|
|
Assert.False(result.IsError);
|
|
Assert.Equal(YouTubeStreamMode.Server, result.Value.Mode);
|
|
Assert.Empty(await Database.ListeningHistories.ToListAsync(TestContext.Current.CancellationToken));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_AnonymousUser_FragmentCapConfigured_UnprovisionedTrack_ReturnsConflictWithoutCallingYouTube()
|
|
{
|
|
var handler = CreateHandler(TestConfigurations.Playback(allowAnonymousListening: true, anonymousFragmentSeconds: 30));
|
|
|
|
var result = await handler.Handle(new ResolveYouTubeTrackStreamCommand("not-provisioned-yet", UserId: null), TestContext.Current.CancellationToken);
|
|
|
|
Assert.Equal(ErrorType.Conflict, result.FirstError.Type);
|
|
await youTubeMusicService.DidNotReceiveWithAnyArgs().GetAudioStreamAsync(default!, TestContext.Current.CancellationToken);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_AnonymousUser_NoFragmentCap_UnprovisionedTrack_FallsBackToDirectYouTubeStream()
|
|
{
|
|
youTubeMusicService.GetAudioStreamAsync("new-video", Arg.Any<CancellationToken>())
|
|
.Returns(new YouTubeStreamInfo("https://youtube.example/stream", 300));
|
|
youTubeMusicService.GetSongAsync("new-video", Arg.Any<CancellationToken>())
|
|
.Returns(new YouTubeSongResult("new-video", "Title", "Artist", "Album", 200, "https://img/thumb.jpg", false, []));
|
|
youTubeMusicService.ResolveArtworkUrl(Arg.Any<string>()).Returns(callInfo => callInfo.Arg<string>());
|
|
|
|
var handler = CreateHandler(TestConfigurations.Playback(allowAnonymousListening: true, anonymousFragmentSeconds: 0));
|
|
|
|
var result = await handler.Handle(new ResolveYouTubeTrackStreamCommand("new-video", UserId: null), TestContext.Current.CancellationToken);
|
|
|
|
Assert.False(result.IsError);
|
|
Assert.Equal(YouTubeStreamMode.YouTube, result.Value.Mode);
|
|
Assert.Empty(await Database.ListeningHistories.ToListAsync(TestContext.Current.CancellationToken));
|
|
}
|
|
}
|
|
}
|