Admin
478b90d75c
Albums previously had no cover concept at all: no picture upload
flow, no GET /albums/{id}/cover, and AlbumApplicationResponse's
image-key fields were plumbed but never populated. Description,
Pictures and TrackCount already lived on the shared Album base entity
for both local and external albums, so unifying the cover story only
required building the missing local-album picture pipeline.
Backend, cloning PlayList's existing async picture-processing
architecture exactly (MassTransit routing slip + saga), but making
the picture mandatory instead of optional (matching Track's pattern):
- AlbumPictures moves from all-nullable to required fields.
- New AlbumConfiguration (routes/sizes), deliberately without
PlayList's preset-picture fallback since a picture is now required
up front.
- CreateAlbum now takes a mandatory PictureIntentId, validates and
consumes the upload intent, and kicks off the same
copy-to-final -> resize -> upload -> update-entity routing slip
PlayLists use, via a new AlbumProcessingState saga that marks the
album Failed on a picture-processing failure.
- UpdateAlbum takes an optional NewPictureIntentId to replace the
cover later.
- New GET /albums/{id}/cover and POST /albums/upload-picture
endpoints, mirroring the playlist ones.
- New EF migration for the AlbumProcessingState saga table.
Frontend:
- AlbumForm gains a cover dropzone, required on create and optional
on edit (via ImageDropzone's new `required` prop), uploaded through
the same presigned-upload helper playlists use.
- New /api/albums/{id}/cover proxy route.
- PlaylistArt gains a generic coverUrl prop so AlbumHeader and the
album list/detail cards render the real uploaded cover instead of
only the track mosaic fallback.
Delete-time picture cleanup for albums is intentionally left as a
follow-up, matching the existing gap in playlist deletion.
78 lines
3.1 KiB
C#
78 lines
3.1 KiB
C#
using ErrorOr;
|
|
using Musify.Application.Albums;
|
|
using Musify.Application.Contracts;
|
|
using Musify.Application.Services;
|
|
using Musify.Application.Tests.TestSupport;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Musify.Application.Tests.Albums
|
|
{
|
|
public sealed class CreateAlbumCommandHandlerTests : HandlerTestBase
|
|
{
|
|
private readonly IEventBus eventBus = Substitute.For<IEventBus>();
|
|
private readonly IStorageService storageService = Substitute.For<IStorageService>();
|
|
|
|
private CreateAlbumCommandHandler CreateHandler() => new(
|
|
eventBus,
|
|
Database,
|
|
new UploadIntentValidator(Database, storageService),
|
|
NoOpLogger<CreateAlbumCommandHandler>(),
|
|
TestConfigurations.Storage(),
|
|
TestConfigurations.Album(),
|
|
TestConfigurations.UploadIntent());
|
|
|
|
[Fact]
|
|
public async Task Handle_ValidPictureIntent_CreatesAlbumAndPublishesResourcesEvent()
|
|
{
|
|
storageService
|
|
.HeadObjectAsync(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<CancellationToken>())
|
|
.Returns(new ObjectMetaData("image/webp", 1024));
|
|
|
|
var owner = TestEntities.User();
|
|
var intent = TestEntities.UploadIntent(owner.Id, Musify.Domain.ValueObjects.UploadIntentPurpose.AlbumPicture, objectName: "cover.webp");
|
|
await SeedAsync(owner, intent);
|
|
|
|
var command = new CreateAlbumCommand(owner.Id, " My Album ", "A description", 2024, intent.Id);
|
|
|
|
var result = await CreateHandler().Handle(command, TestContext.Current.CancellationToken);
|
|
|
|
Assert.False(result.IsError);
|
|
Assert.Equal("My Album", result.Value.Title);
|
|
Assert.Equal("A description", result.Value.Description);
|
|
Assert.Equal(2024, result.Value.ReleaseYear);
|
|
Assert.Equal(owner.Id, result.Value.OwnerUserId);
|
|
Assert.Equal(0, result.Value.TrackCount);
|
|
|
|
var stored = await Database.UserAlbums.FindAsync([result.Value.Id], TestContext.Current.CancellationToken);
|
|
Assert.NotNull(stored);
|
|
Assert.Equal("MY ALBUM", stored.NormalizedTitle);
|
|
Assert.Equal("cover.webp", stored.Pictures.OriginalName);
|
|
await eventBus.Received(1).PublishAsync(Arg.Any<Musify.Application.Events.CreateAlbumResourcesEvent>(), Arg.Any<CancellationToken>());
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_UserDoesNotExist_ReturnsNotFound()
|
|
{
|
|
var command = new CreateAlbumCommand(404, "Orphan Album", null, null, Guid.NewGuid());
|
|
|
|
var result = await CreateHandler().Handle(command, TestContext.Current.CancellationToken);
|
|
|
|
Assert.Equal(ErrorType.NotFound, result.FirstError.Type);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Handle_PictureIntentNotFound_ReturnsError()
|
|
{
|
|
var owner = TestEntities.User();
|
|
await SeedAsync(owner);
|
|
|
|
var command = new CreateAlbumCommand(owner.Id, "My Album", null, null, Guid.NewGuid());
|
|
|
|
var result = await CreateHandler().Handle(command, TestContext.Current.CancellationToken);
|
|
|
|
Assert.True(result.IsError);
|
|
}
|
|
}
|
|
}
|