- Document every endpoint's responses (Produces<T>/status codes/validation) so the generated OpenAPI/Scalar docs carry response schemas and status codes instead of empty responses - Cache recently-synced user ids (IMemoryCache, 15 min) in the JWT TokenValidated handler so user provisioning no longer hits the DB on every authenticated request - Add ProblemDetails + UseExceptionHandler for consistent RFC7807 errors - Add ToCreatedResult ErrorOr helper and use it in the create endpoints - Normalize the playlists route to lowercase (/playlists) Verified: booted the Api against RabbitMQ + Postgres in Docker and inspected /openapi/v1.json — operations now expose response schemas/status codes and the route is /playlists. Build: 0 warnings, 0 errors.
44 lines
1.5 KiB
C#
44 lines
1.5 KiB
C#
using ErrorOr;
|
|
using IResult = Microsoft.AspNetCore.Http.IResult;
|
|
|
|
namespace Musify.Api.Extensions;
|
|
|
|
public static class ErrorOrHttpExtensions
|
|
{
|
|
public static IResult ToHttpResult<T>(this ErrorOr<T> result)
|
|
{
|
|
if (result.IsError)
|
|
return Problem(result.Errors);
|
|
|
|
return result.Value is Success
|
|
? Results.NoContent()
|
|
: Results.Ok(result.Value);
|
|
}
|
|
|
|
public static IResult ToCreatedResult<T>(this ErrorOr<T> result, Func<T, string> locationFactory) =>
|
|
result.IsError
|
|
? Problem(result.Errors)
|
|
: Results.Created(locationFactory(result.Value), result.Value);
|
|
|
|
private static IResult Problem(List<Error> errors)
|
|
{
|
|
if (errors.All(e => e.Type == ErrorType.Validation))
|
|
return Results.ValidationProblem(ToValidationDictionary(errors));
|
|
|
|
var error = errors[0];
|
|
return error.Type switch
|
|
{
|
|
ErrorType.NotFound => Results.NotFound(error.Description),
|
|
ErrorType.Unauthorized => Results.Unauthorized(),
|
|
ErrorType.Forbidden => Results.StatusCode(StatusCodes.Status403Forbidden),
|
|
ErrorType.Conflict => Results.Conflict(error.Description),
|
|
_ => Results.Problem(error.Description)
|
|
};
|
|
}
|
|
|
|
private static Dictionary<string, string[]> ToValidationDictionary(IEnumerable<Error> errors) =>
|
|
errors
|
|
.GroupBy(e => string.IsNullOrEmpty(e.Code) ? "general" : e.Code)
|
|
.ToDictionary(g => g.Key, g => g.Select(e => e.Description).ToArray());
|
|
}
|