Admin
a26f4b43fd
Second pass on backend/Tests/, covering what Domain+Application (the first
pass) deliberately left out — the parts that talk to real infrastructure:
Musify.Infrastructure.Tests Database/migrations, StorageService,
StreamTicketService, AuditableEntityInterceptor,
PictureService, SingleFlightCache,
PlayListPresetSeeder.
Musify.Api.Tests Real HTTP endpoints via WebApplicationFactory
(routing, auth, ValidationFilter, ErrorOr->HTTP
mapping), plus isolated unit tests for
ErrorOrHttpExtensions, CurrentUser and the
FluentValidation validators.
Musify.StreamingGateway.Tests TicketValidator (RS256) and
TicketValidationMiddleware (path traversal,
prefix boundary, ticket extraction).
Musify.Worker gets no test project: its Program.cs is pure DI/host wiring
(Hangfire, MassTransit, jobs); the logic it runs lives in Musify.Infrastructure,
already covered there.
Per the user's direction, the parts that touch real infrastructure use
Testcontainers instead of fakes: a real Postgres (Testcontainers.PostgreSql)
for Infrastructure.Tests and Api.Tests, and — matching deploy/compose.yml
exactly (chrislusf/seaweedfs:latest, same startup command), not MinIO — a
real SeaweedFS container for StorageService. Api.Tests boots the actual
Musify.Api host against that Postgres (real routing/auth/validation) but
substitutes the services that talk over the network (storage, YouTube, the
message bus, stream-ticket signing) with NSubstitute fakes, and swaps the
JwtBearer scheme for a test-only header-based one (FakeAuthenticationHandler)
so tests don't need a reachable Zitadel. Application.Tests' approach — a real
DbContext (SQLite in-memory) rather than mocking IDatabase, since it exposes
DbSet<T> directly and handlers compose real LINQ queries against it — carries
over into Infrastructure.Tests/Api.Tests via real Postgres instead.
Testing against the real backend (not a fake) found two genuine production
bugs, both fixed here:
- StorageService.RemoveFolderAsync threw NullReferenceException against
SeaweedFS: its DeleteObjects response omits the <Error> list entirely when
nothing failed, which the AWS SDK deserializes as null rather than an empty
list (real AWS S3 always returns one). Now treats null as no errors.
- AuditableEntityInterceptor never bumped UpdatedAt on a normal update (load,
mutate a property, SaveChanges) — only on insert. SavingChanges(Async) fires
before EF's own automatic change detection for that save, so an entity
modified through a plain property setter still reported EntityState.Unchanged
inside the interceptor. Now calls ChangeTracker.DetectChanges() explicitly
first, which is the documented fix for exactly this interceptor pattern.
Also required to make the Api host testable: Program.cs now ends with `public
partial class Program;` (WebApplicationFactory<Program> needs the top-level-
statements Program class to be public — no behavior change), and
Directory.Packages.props gains Microsoft.AspNetCore.Mvc.Testing, Testcontainers
and Testcontainers.PostgreSql.
249 tests total across all five projects, all green: `dotnet test
backend/Musify.slnx` (needs Docker running for Infrastructure.Tests and
Api.Tests).
47 lines
1.7 KiB
C#
47 lines
1.7 KiB
C#
using Microsoft.EntityFrameworkCore;
|
|
using Musify.Domain.Entities;
|
|
using Musify.Infrastructure.Tests.TestSupport;
|
|
using Xunit;
|
|
|
|
namespace Musify.Infrastructure.Tests.Persistence;
|
|
|
|
[Collection(InfrastructureCollection.Name)]
|
|
public sealed class AuditableEntityInterceptorTests(InfrastructureTestFixture fixture)
|
|
{
|
|
[Fact]
|
|
public async Task SavingChanges_NewEntity_SetsCreatedAtAndUpdatedAtToNow()
|
|
{
|
|
await using var database = fixture.CreateDatabase();
|
|
var before = DateTime.UtcNow;
|
|
|
|
var user = new User { Id = Random.Shared.NextInt64(1, long.MaxValue), Name = "audit-user", NormalizedName = "AUDIT-USER" };
|
|
await database.Users.AddAsync(user);
|
|
await database.SaveChangesAsync(CancellationToken.None);
|
|
|
|
var after = DateTime.UtcNow;
|
|
|
|
Assert.InRange(user.CreatedAt, before, after);
|
|
Assert.InRange(user.UpdatedAt, before, after);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SavingChanges_ModifiedEntity_BumpsUpdatedAtButKeepsCreatedAt()
|
|
{
|
|
await using var database = fixture.CreateDatabase();
|
|
|
|
var user = new User { Id = Random.Shared.NextInt64(1, long.MaxValue), Name = "audit-user-2", NormalizedName = "AUDIT-USER-2" };
|
|
await database.Users.AddAsync(user);
|
|
await database.SaveChangesAsync(CancellationToken.None);
|
|
var originalCreatedAt = user.CreatedAt;
|
|
|
|
await Task.Delay(TimeSpan.FromMilliseconds(50));
|
|
|
|
user.Name = "audit-user-2-renamed";
|
|
await database.SaveChangesAsync(CancellationToken.None);
|
|
|
|
Assert.Equal(originalCreatedAt, user.CreatedAt);
|
|
Assert.True(user.UpdatedAt > originalCreatedAt,
|
|
$"original-created-at={originalCreatedAt:O}, final-updated-at={user.UpdatedAt:O}");
|
|
}
|
|
}
|