AdminandClaude Opus 4.8
d08d82a483
Fix (recoverability bug): - TransferFilesToBucketActivity returned Completed() with no log, so its compensation could never delete the transferred files (orphaned objects on fault). IStorageService.TransferFilesAsync now returns the real uploaded keys; the activity logs them so Compensate can remove them. Also drops the Path.Combine key recomputation (produced backslash keys on Windows). Consistency / DRY: - Normalize all courier activities to internal + folder-based namespaces (several were public and in the flat .Activities namespace) - Extract the duplicated exponential retry into UseStandardRetry - Unify endpoint-name logic into a single EndpointHelper (remove the parallel MassTransitEndpointNames helper) Build: 0 warnings, 0 errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
51 lines
2.5 KiB
C#
51 lines
2.5 KiB
C#
using MassTransit;
|
|
using Microsoft.Extensions.Logging;
|
|
using Musify.Infrastructure.MassTransit.Arguments;
|
|
|
|
namespace Musify.Infrastructure.MassTransit.Activities.Pictures
|
|
{
|
|
internal class GeneratePictureWorkflowPathsActivity(
|
|
ILogger<GeneratePictureWorkflowPathsActivity> logger)
|
|
: IExecuteActivity<GeneratePictureWorkflowPathsArguments>
|
|
{
|
|
public const string ExecuteEndpointName = "generate-picture-workflow-paths";
|
|
|
|
internal const string ResizedPictureFileExtension = ".webp";
|
|
|
|
public async Task<ExecutionResult> Execute(ExecuteContext<GeneratePictureWorkflowPathsArguments> executeContext)
|
|
{
|
|
try
|
|
{
|
|
var workingDirectory = Path.Combine(executeContext.Arguments.TemporaryRootDirectory, Guid.NewGuid().ToString());
|
|
|
|
var sourceFilePath = Path.Combine(
|
|
workingDirectory, Guid.NewGuid().ToString() + Path.GetExtension(executeContext.Arguments.SourceKey));
|
|
var smallPictureFilePath = Path.Combine(
|
|
workingDirectory, Guid.NewGuid().ToString() + ResizedPictureFileExtension);
|
|
var mediumPictureFilePath = Path.Combine(
|
|
workingDirectory, Guid.NewGuid().ToString() + ResizedPictureFileExtension);
|
|
var largePictureFilePath = Path.Combine(
|
|
workingDirectory, Guid.NewGuid().ToString() + ResizedPictureFileExtension);
|
|
|
|
Directory.CreateDirectory(workingDirectory);
|
|
|
|
logger.LogDebug("Generated picture workflow paths in {WorkingDirectory}",
|
|
workingDirectory);
|
|
return executeContext.CompletedWithVariables(new Dictionary<string, object>
|
|
{
|
|
[RoutingSlipVariableNames.Workflow.TemporalDirectory] = workingDirectory,
|
|
[RoutingSlipVariableNames.Picture.OriginalFilePath] = sourceFilePath,
|
|
[RoutingSlipVariableNames.Picture.SmallResizedFilePath] = smallPictureFilePath,
|
|
[RoutingSlipVariableNames.Picture.MediumResizedFilePath] = mediumPictureFilePath,
|
|
[RoutingSlipVariableNames.Picture.LargeResizedFilePath] = largePictureFilePath
|
|
} );
|
|
}
|
|
catch (Exception exception)
|
|
{
|
|
logger.LogError(exception, "Failed to generate picture workflow paths for {SourceKey}",
|
|
executeContext.Arguments.SourceKey);
|
|
throw;
|
|
}
|
|
}
|
|
}
|
|
} |